[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-ppc] [PATCH qemu v13 12/16] vmstate: Define VARRA
From: |
David Gibson |
Subject: |
Re: [Qemu-devel] [Qemu-ppc] [PATCH qemu v13 12/16] vmstate: Define VARRAY with VMS_ALLOC |
Date: |
Thu, 3 Mar 2016 17:31:24 +1100 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Tue, Mar 01, 2016 at 08:10:37PM +1100, Alexey Kardashevskiy wrote:
> This allows dynamic allocation for migrating arrays.
>
> Already existing VMSTATE_VARRAY_UINT32 requires an array to be
> pre-allocated, however there are cases when the size is not known in
> advance and there is no real need to enforce it.
>
> This defines another variant of VMSTATE_VARRAY_UINT32 with WMS_ALLOC
> flag which tells the receiving side to allocate memory for the array
> before receiving the data.
>
> The first user of it is a dynamic DMA window which existence and size
> are totally dynamic.
>
> Signed-off-by: Alexey Kardashevskiy <address@hidden>
> Reviewed-by: David Gibson <address@hidden>
> Reviewed-by: Thomas Huth <address@hidden>
This looks fine, but it might be worth sending separately, to seek
review from Juan or Dave Gilbert.
> ---
> include/migration/vmstate.h | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h
> index 84ee355..1622638 100644
> --- a/include/migration/vmstate.h
> +++ b/include/migration/vmstate.h
> @@ -386,6 +386,16 @@ extern const VMStateInfo vmstate_info_bitmap;
> .offset = vmstate_offset_pointer(_state, _field, _type), \
> }
>
> +#define VMSTATE_VARRAY_UINT32_ALLOC(_field, _state, _field_num, _version,
> _info, _type) {\
> + .name = (stringify(_field)), \
> + .version_id = (_version), \
> + .num_offset = vmstate_offset_value(_state, _field_num, uint32_t),\
> + .info = &(_info), \
> + .size = sizeof(_type), \
> + .flags = VMS_VARRAY_UINT32|VMS_POINTER|VMS_ALLOC, \
> + .offset = vmstate_offset_pointer(_state, _field, _type), \
> +}
> +
> #define VMSTATE_VARRAY_UINT16_UNSAFE(_field, _state, _field_num, _version,
> _info, _type) {\
> .name = (stringify(_field)), \
> .version_id = (_version), \
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
- [Qemu-devel] [PATCH qemu v13 00/16] spapr: vfio: Enable Dynamic DMA windows (DDW), Alexey Kardashevskiy, 2016/03/01
- [Qemu-devel] [PATCH qemu v13 01/16] memory: Fix IOMMU replay base address, Alexey Kardashevskiy, 2016/03/01
- [Qemu-devel] [PATCH qemu v13 12/16] vmstate: Define VARRAY with VMS_ALLOC, Alexey Kardashevskiy, 2016/03/01
- Re: [Qemu-devel] [Qemu-ppc] [PATCH qemu v13 12/16] vmstate: Define VARRAY with VMS_ALLOC,
David Gibson <=
- [Qemu-devel] [PATCH qemu v13 10/16] vfio: Use different page size for different IOMMU types, Alexey Kardashevskiy, 2016/03/01
- [Qemu-devel] [PATCH qemu v13 09/16] vfio: Generalize IOMMU memory listener, Alexey Kardashevskiy, 2016/03/01
[Qemu-devel] [PATCH qemu v13 14/16] spapr_pci: Add and export DMA resetting helper, Alexey Kardashevskiy, 2016/03/01
[Qemu-devel] [PATCH qemu v13 05/16] spapr_iommu: Add root memory region, Alexey Kardashevskiy, 2016/03/01