[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] hw/usb: whitespace fix in tusb6010.c
From: |
xiaoqiang zhao |
Subject: |
Re: [Qemu-devel] [PATCH] hw/usb: whitespace fix in tusb6010.c |
Date: |
Thu, 3 Mar 2016 21:51:10 +0800 |
>> 在 2016年3月3日,21:23,Peter Maydell <address@hidden> 写道:
>>
>> On 3 March 2016 at 06:19, xiaoqiang zhao <address@hidden> wrote:
>> use spaces instead of Tabs
>>
>> Signed-off-by: xiaoqiang zhao <address@hidden>
>> ---
>> hw/usb/tusb6010.c | 318
>> +++++++++++++++++++++++++++---------------------------
>> 1 file changed, 159 insertions(+), 159 deletions(-)
>
> That's a lot of churn -- we don't usually worry about doing whitespace
> cleanups unless somebody's immediately going to do a lot of work on
> the device (in which case the ws cleanup is usually the first patch
> in the series as preparation for the patches doing the interesting
> stuff.)
>
> The rationale for not doing big whitespace or style cleanups is that
> it makes tools like 'git blame' less useful for looking at the
> history of lines in the file.
>
> thanks
> -- PMM
I see. Thank you peter!