[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 15/18] loader: add API to load elf header
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v2 15/18] loader: add API to load elf header |
Date: |
Thu, 3 Mar 2016 15:24:51 +0000 |
On 2 March 2016 at 06:56, Peter Crosthwaite <address@hidden> wrote:
> Add an API to load an elf header header from a file. Populates a
> buffer with the header contents, as well as a boolean for whether the
> elf is 64b or not. Both arguments are optional.
>
> Signed-off-by: Peter Crosthwaite <address@hidden>
> ---
> Changed since v1 (PMM review):
> Add filname to error messages
> Remove unneeded lseek()
> Add doc comment
> +/** load_elf_hdr:
> + * @filename: Path of ELF file
> + * @hdr: Buffer to populate with header data. Header data will not be
> + * filled if set to NULL.
> + * @is64: Set to true if the ELF is 64bit. Ignored if set to NULL
> + * @errp: Populated with an error in failure cases
> + *
> + * Inspect as ELF file's header. Read its full header contents into a
"an".
> + * buffer and/or determine if the ELF is 64bit.
> + */
Otherwise
Reviewed-by: Peter Maydell <address@hidden>
thanks
-- PMM
- [Qemu-devel] [PATCH v2 06/18] linux-user: arm: set CPSR.E/SCTLR.E0E correctly for BE mode, (continued)
- [Qemu-devel] [PATCH v2 06/18] linux-user: arm: set CPSR.E/SCTLR.E0E correctly for BE mode, Peter Crosthwaite, 2016/03/02
- [Qemu-devel] [PATCH v2 07/18] linux-user: arm: handle CPSR.E correctly in strex emulation, Peter Crosthwaite, 2016/03/02
- [Qemu-devel] [PATCH v2 08/18] target-arm: implement SCTLR.EE, Peter Crosthwaite, 2016/03/02
- [Qemu-devel] [PATCH v2 10/18] target-arm: introduce disas flag for endianness, Peter Crosthwaite, 2016/03/02
- [Qemu-devel] [PATCH v2 09/18] target-arm: pass DisasContext to gen_aa32_ld*/st*, Peter Crosthwaite, 2016/03/02
- [Qemu-devel] [PATCH v2 11/18] target-arm: a64: Add endianness support, Peter Crosthwaite, 2016/03/02
- [Qemu-devel] [PATCH v2 12/18] target-arm: introduce tbflag for endianness, Peter Crosthwaite, 2016/03/02
- [Qemu-devel] [PATCH v2 13/18] target-arm: implement setend, Peter Crosthwaite, 2016/03/02
- [Qemu-devel] [PATCH v2 15/18] loader: add API to load elf header, Peter Crosthwaite, 2016/03/02
- Re: [Qemu-devel] [PATCH v2 15/18] loader: add API to load elf header,
Peter Maydell <=
- [Qemu-devel] [PATCH v2 16/18] loader: load_elf(): Add doc comment, Peter Crosthwaite, 2016/03/02
- [Qemu-devel] [PATCH v2 17/18] loader: Add data swap option to load-elf, Peter Crosthwaite, 2016/03/02
- [Qemu-devel] [PATCH v2 18/18] arm: boot: Support big-endian elfs, Peter Crosthwaite, 2016/03/02
- Re: [Qemu-devel] [PATCH v2 00/18] ARM big-endian and setend support, Peter Maydell, 2016/03/03
- Message not available