[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-arm] [PATCH] target-arm: Fix translation level on
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [Qemu-arm] [PATCH] target-arm: Fix translation level on early translation faults |
Date: |
Thu, 3 Mar 2016 16:54:38 +0000 |
On 3 March 2016 at 16:37, Sergey Fedorov <address@hidden> wrote:
> On 03.03.2016 17:55, Peter Maydell wrote:
>> Yes, this patch is definitely fixing a bug; I'm just mentioning that other
>> code path because it seems to be the result of previously fixing the bug
>> for a particular special case...
>>
>>
>
> Ah, right, I think I understand you :) So we'd better remove these lines:
>
> /* AArch64 reports these as level 0 faults.
> * AArch32 reports these as level 1 faults.
> */
> level = va_size == 64 ? 0 : 1;
> fault_type = translation_fault;
Those lines come after some code which has set level to something
else, so you'd need to rearrange that code a bit so it didn't
set level before it had determined that there wasn't a fault.
thanks
-- PMM
- [Qemu-devel] [PATCH] target-arm: Fix translation level on early translation faults, Sergey Sorokin, 2016/03/02
- Re: [Qemu-devel] [PATCH] target-arm: Fix translation level on early translation faults, Sergey Fedorov, 2016/03/02
- Re: [Qemu-devel] [PATCH] target-arm: Fix translation level on early translation faults, Peter Maydell, 2016/03/03
- Re: [Qemu-devel] [PATCH] target-arm: Fix translation level on early translation faults, Sergey Fedorov, 2016/03/03
- Re: [Qemu-devel] [Qemu-arm] [PATCH] target-arm: Fix translation level on early translation faults, Peter Maydell, 2016/03/03
- Re: [Qemu-devel] [Qemu-arm] [PATCH] target-arm: Fix translation level on early translation faults, Sergey Fedorov, 2016/03/03
- Re: [Qemu-devel] [Qemu-arm] [PATCH] target-arm: Fix translation level on early translation faults,
Peter Maydell <=
- Re: [Qemu-devel] [Qemu-arm] [PATCH] target-arm: Fix translation level on early translation faults, Sergey Sorokin, 2016/03/04
- Re: [Qemu-devel] [Qemu-arm] [PATCH] target-arm: Fix translation level on early translation faults, Peter Maydell, 2016/03/04
Re: [Qemu-devel] [PATCH] target-arm: Fix translation level on early translation faults, Sergey Fedorov, 2016/03/02