[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v15 8/9] Implement new driver for block replicat
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v15 8/9] Implement new driver for block replication |
Date: |
Fri, 4 Mar 2016 17:53:39 +0000 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Fri, Feb 05, 2016 at 12:18:07PM +0800, Changlong Xie wrote:
> +static void secondary_do_checkpoint(BDRVReplicationState *s, Error **errp)
> +{
> + Error *local_err = NULL;
> + int ret;
> +
> + if (!s->secondary_disk->bs->job) {
> + error_setg(errp, "Backup job was cancelled unexpectedly");
> + return;
> + }
Do you have test cases for the replication driver?
This error code path seems like something that should be exercised to
make sure it works.
Basic start/checkpoint/stop and checks that the active/secondary/hidden
disks contain the expected data are also important.
Probably the easiest way to do this would be a file called
tests/test-replication.c that calls start/checkpoint/stop and read/write
functions directly instead of running a guest.
signature.asc
Description: PGP signature