[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH] net.c: Moved large array in nc_sendv_compat from th
From: |
Nikos Filippakis |
Subject: |
[Qemu-devel] [PATCH] net.c: Moved large array in nc_sendv_compat from the stack to the heap |
Date: |
Sat, 5 Mar 2016 22:39:41 +0200 |
Hello everyone! I am interested in getting to know the codebase a little better
so that I can eventually apply for a GSOC position.
This is my first attempt at posting a patch to a mailing list, any feedback
is greatly appreciated.
Signed-off-by: Nikos Filippakis <address@hidden>
---
net/net.c | 17 ++++++++++++-----
1 file changed, 12 insertions(+), 5 deletions(-)
diff --git a/net/net.c b/net/net.c
index aebf753..79e9d7c 100644
--- a/net/net.c
+++ b/net/net.c
@@ -710,23 +710,30 @@ ssize_t qemu_send_packet_raw(NetClientState *nc, const
uint8_t *buf, int size)
static ssize_t nc_sendv_compat(NetClientState *nc, const struct iovec *iov,
int iovcnt, unsigned flags)
{
- uint8_t buf[NET_BUFSIZE];
uint8_t *buffer;
size_t offset;
+ ssize_t ret;
if (iovcnt == 1) {
buffer = iov[0].iov_base;
offset = iov[0].iov_len;
} else {
- buffer = buf;
- offset = iov_to_buf(iov, iovcnt, 0, buf, sizeof(buf));
+ buffer = g_malloc(NET_BUFSIZE * sizeof(uint8_t));
+ offset = iov_to_buf(iov, iovcnt, 0, buffer,
+ NET_BUFSIZE * sizeof(uint8_t));
}
if (flags & QEMU_NET_PACKET_FLAG_RAW && nc->info->receive_raw) {
- return nc->info->receive_raw(nc, buffer, offset);
+ ret = nc->info->receive_raw(nc, buffer, offset);
} else {
- return nc->info->receive(nc, buffer, offset);
+ ret = nc->info->receive(nc, buffer, offset);
}
+
+ if (iovcnt != 1) {
+ g_free(buffer);
+ }
+
+ return ret;
}
ssize_t qemu_deliver_packet_iov(NetClientState *sender,
--
1.9.1
- [Qemu-devel] [PATCH] net.c: Moved large array in nc_sendv_compat from the stack to the heap,
Nikos Filippakis <=