[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] scripts: Fix dump-guest-memory.py for MemoryReg
From: |
Laszlo Ersek |
Subject: |
Re: [Qemu-devel] [PATCH] scripts: Fix dump-guest-memory.py for MemoryRegion.ram_block removal |
Date: |
Mon, 7 Mar 2016 11:08:45 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 |
On 03/07/16 10:45, Fam Zheng wrote:
> On Mon, 03/07 10:37, Laszlo Ersek wrote:
>> On 03/07/16 10:17, Fam Zheng wrote:
>>> Signed-off-by: Fam Zheng <address@hidden>
>>>
>>> ---
>>>
>>> This goes after "[PATCH v2 4/7] memory: Drop MemoryRegion.ram_addr" (or
>>> squashed into it if we want strict synchronization).
>>> ---
>>> scripts/dump-guest-memory.py | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/scripts/dump-guest-memory.py b/scripts/dump-guest-memory.py
>>> index f274bf8..c0a2e99 100644
>>> --- a/scripts/dump-guest-memory.py
>>> +++ b/scripts/dump-guest-memory.py
>>> @@ -352,7 +352,7 @@ def memory_region_get_ram_ptr(memory_region):
>>> return
>>> (memory_region_get_ram_ptr(memory_region["alias"].dereference())
>>> + memory_region["alias_offset"])
>>>
>>> - return qemu_get_ram_ptr(memory_region["ram_addr"] & TARGET_PAGE_MASK)
>>> + return qemu_get_ram_ptr(memory_region["ram_block"]["offset"])
>>>
>>>
>>> def get_guest_phys_blocks():
>>>
>>
>> I didn't follow your series, and I've by now forgotten most of the dump
>> stuff, but if you tested the above with GDB, I can ack it.
>
> For the record, yes, I've tested it on top of this series and the command
> works
> for me.
Fantastic, thanks a lot!
Laszlo
>>
>> Acked-by: Laszlo Ersek <address@hidden>
>>
>> I hope that Janosch can chime in as well.
>>
>> Thanks
>> Laszlo
- [Qemu-devel] [PATCH v2 0/7] memory: Clean up MemoryRegion.ram_addr and optimize address_space_translate, Fam Zheng, 2016/03/01
- [Qemu-devel] [PATCH v2 1/7] exec: Return RAMBlock pointer from allocating functions, Fam Zheng, 2016/03/01
- [Qemu-devel] [PATCH v2 2/7] memory: Move assignment to ram_block to memory_region_init_*, Fam Zheng, 2016/03/01
- [Qemu-devel] [PATCH v2 3/7] memory: Implement memory_region_get_ram_addr with mr->ram_block, Fam Zheng, 2016/03/01
- [Qemu-devel] [PATCH v2 4/7] memory: Drop MemoryRegion.ram_addr, Fam Zheng, 2016/03/01
- Re: [Qemu-devel] [PATCH] scripts: Fix dump-guest-memory.py for MemoryRegion.ram_block removal, Paolo Bonzini, 2016/03/07
- Re: [Qemu-devel] [PATCH] scripts: Fix dump-guest-memory.py for MemoryRegion.ram_block removal, Janosch Frank, 2016/03/07
- Re: [Qemu-devel] [PATCH] scripts: Fix dump-guest-memory.py for MemoryRegion.ram_block removal, Janosch Frank, 2016/03/08
- Re: [Qemu-devel] [PATCH] scripts: Fix dump-guest-memory.py for MemoryRegion.ram_block removal, Fam Zheng, 2016/03/08
[Qemu-devel] [PATCH v2 5/7] exec: Pass RAMBlock pointer to qemu_ram_free, Fam Zheng, 2016/03/01
[Qemu-devel] [PATCH v2 6/7] exec: Factor out section_covers_addr, Fam Zheng, 2016/03/01
[Qemu-devel] [PATCH v2 7/7] exec: Introduce AddressSpaceDispatch.mru_section, Fam Zheng, 2016/03/01