[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/6] acpi: simplify bios_linker API
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH 0/6] acpi: simplify bios_linker API |
Date: |
Mon, 7 Mar 2016 17:28:29 +0200 |
On Mon, Mar 07, 2016 at 04:19:02PM +0100, Igor Mammedov wrote:
> Simplify bios_linker API by adding filei name + blob tracking
> so user would have to suppily less arguments which
> reduces chances of mistake by using wrong blob pointer
> with not related file.
> And also refactor API to take file offsets, as it's what
> actually API were doing only internally, instead of
> using host pointers. I hope ti makes it easier for API user
> to use API without need to look at implementation on
> QEMU/SeaBIOS.
Thanks!
As we are in freeze, I'll probably defer this until after the release though.
> Igor Mammedov (6):
> acpi: convert linker from GArray to BOISLinker structure
> acpi: simplify bios_linker API by removing redundant 'table' argument
> acpi: cleanup bios_linker_loader_cleanup()
> tpm: apci: cleanup TCPA table initialization
> acpi: make bios_linker_loader_add_pointer() API offset based
> acpi: make bios_linker_loader_add_checksum() API offset based
>
> hw/acpi/aml-build.c | 33 +++----
> hw/acpi/bios-linker-loader.c | 179
> +++++++++++++++++++++--------------
> hw/acpi/nvdimm.c | 6 +-
> hw/arm/virt-acpi-build.c | 51 +++++-----
> hw/i386/acpi-build.c | 89 +++++++++--------
> include/hw/acpi/aml-build.h | 7 +-
> include/hw/acpi/bios-linker-loader.h | 28 +++---
> include/hw/mem/nvdimm.h | 3 +-
> 8 files changed, 222 insertions(+), 174 deletions(-)
>
> --
> 1.8.3.1
- [Qemu-devel] [PATCH 0/6] acpi: simplify bios_linker API, Igor Mammedov, 2016/03/07
- [Qemu-devel] [PATCH 1/6] acpi: convert linker from GArray to BOISLinker structure, Igor Mammedov, 2016/03/07
- [Qemu-devel] [PATCH 3/6] acpi: cleanup bios_linker_loader_cleanup(), Igor Mammedov, 2016/03/07
- [Qemu-devel] [PATCH 4/6] tpm: apci: cleanup TCPA table initialization, Igor Mammedov, 2016/03/07
- [Qemu-devel] [PATCH 2/6] acpi: simplify bios_linker API by removing redundant 'table' argument, Igor Mammedov, 2016/03/07
- [Qemu-devel] [PATCH 6/6] acpi: make bios_linker_loader_add_checksum() API offset based, Igor Mammedov, 2016/03/07
- [Qemu-devel] [PATCH 5/6] acpi: make bios_linker_loader_add_pointer() API offset based, Igor Mammedov, 2016/03/07
- Re: [Qemu-devel] [PATCH 0/6] acpi: simplify bios_linker API,
Michael S. Tsirkin <=