[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] loader: Fix incorrect parameter name in load_im
From: |
Laszlo Ersek |
Subject: |
Re: [Qemu-devel] [PATCH] loader: Fix incorrect parameter name in load_image_mr() macro |
Date: |
Wed, 9 Mar 2016 00:14:13 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 |
On 03/08/16 01:23, Peter Maydell wrote:
> From: Jens Wiklander <address@hidden>
>
> Fix a typo in the load_image_mr() macro: 'mr' was written when
> the parameter name is '_mr'. (This had no visible effects since
> the single use of the macro used 'mr' as the argument.)
>
> Fixes 76151cacfe956248a25b38b5e8429465584f47bb "loader: Add
> load_image_mr() to load ROM image to a MemoryRegion"
>
> Signed-off-by: Jens Wiklander <address@hidden>
> Reviewed-by: Peter Maydell <address@hidden>
> [PMM: tweaked commit message]
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> Oops...
>
> include/hw/loader.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/hw/loader.h b/include/hw/loader.h
> index 0ba7808..b3d1358 100644
> --- a/include/hw/loader.h
> +++ b/include/hw/loader.h
> @@ -137,7 +137,7 @@ void hmp_info_roms(Monitor *mon, const QDict *qdict);
> #define rom_add_blob_fixed(_f, _b, _l, _a) \
> rom_add_blob(_f, _b, _l, _l, _a, NULL, NULL, NULL)
> #define rom_add_file_mr(_f, _mr, _i) \
> - rom_add_file(_f, NULL, 0, _i, false, mr)
> + rom_add_file(_f, NULL, 0, _i, false, _mr)
>
> #define PC_ROM_MIN_VGA 0xc0000
> #define PC_ROM_MIN_OPTION 0xc8000
>
Reviewed-by: Laszlo Ersek <address@hidden>