[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH] usb: fix unbound stack warning for inotify_watchfn
From: |
Peter Xu |
Subject: |
[Qemu-devel] [PATCH] usb: fix unbound stack warning for inotify_watchfn |
Date: |
Wed, 9 Mar 2016 14:07:20 +0800 |
Signed-off-by: Peter Xu <address@hidden>
---
hw/usb/dev-mtp.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c
index 7391783..76ad64e 100644
--- a/hw/usb/dev-mtp.c
+++ b/hw/usb/dev-mtp.c
@@ -433,12 +433,11 @@ static void inotify_watchfn(void *arg)
MTPState *s = arg;
ssize_t bytes;
/* From the man page: atleast one event can be read */
- int len = sizeof(struct inotify_event) + NAME_MAX + 1;
int pos;
- char buf[len];
+ char buf[sizeof(struct inotify_event) + NAME_MAX + 1];
for (;;) {
- bytes = read(s->inotifyfd, buf, len);
+ bytes = read(s->inotifyfd, buf, sizeof(buf));
pos = 0;
if (bytes <= 0) {
--
2.4.3
- [Qemu-devel] [PATCH] usb: fix unbound stack warning for inotify_watchfn,
Peter Xu <=