[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 01/10] qdict: implement a qdict_crumple metho
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [PATCH v2 01/10] qdict: implement a qdict_crumple method for un-flattening a dict |
Date: |
Wed, 9 Mar 2016 19:16:03 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 |
On 09.03.2016 19:07, Daniel P. Berrange wrote:
> On Mon, Mar 07, 2016 at 06:23:35PM +0100, Max Reitz wrote:
>> On 07.03.2016 16:43, Daniel P. Berrange wrote:
[...]
>>> +static void qdict_crumple_test_recursive(void)
>>> +{
>>> + QDict *src, *dst, *rule;
>>> + QObject *child;
>>> + QList *rules;
>>> +
>>> + src = qdict_new();
>>> + qdict_put(src, "rule.0.match", qstring_from_str("fred"));
>>> + qdict_put(src, "rule.0.policy", qstring_from_str("allow"));
>>> + qdict_put(src, "rule.1.match", qstring_from_str("bob"));
>>> + qdict_put(src, "rule.1.policy", qstring_from_str("deny"));
>>> +
>>> + dst = (QDict *)qdict_crumple(src, true, &error_abort);
>>> +
>>> + g_assert_cmpint(qdict_size(dst), ==, 1);
>>> +
>>> + child = qdict_get(dst, "rule");
>>> + g_assert_cmpint(qobject_type(child), ==, QTYPE_QLIST);
>>> +
>>> + rules = qdict_get_qlist(dst, "rule");
>>> + g_assert_cmpint(qlist_size(rules), ==, 2);
>>> +
>>> + rule = qobject_to_qdict(qlist_pop(rules));
>>
>> g_assert_cmpint(qdict_size(rule), ==, 2); ?
>>
>>> + g_assert_cmpstr("fred", ==, qdict_get_str(rule, "match"));
>>> + g_assert_cmpstr("allow", ==, qdict_get_str(rule, "policy"));
>>> + QDECREF(rule);
>>> +
>>> + rule = qobject_to_qdict(qlist_pop(rules));
>>
>>
>> g_assert_cmpint(qdict_size(rule), ==, 2); ?
>>
>>> + g_assert_cmpstr("bob", ==, qdict_get_str(rule, "match"));
>>> + g_assert_cmpstr("deny", ==, qdict_get_str(rule, "policy"));
>>> + QDECREF(rule);
>>> +
>>> + QDECREF(src);
>>> + QDECREF(dst);
>>
>> QDECREF(rules);
>
> rules is a borrowed reference, so we can't decrement it.
Oops, right. :-)
I suppose it looked so tempting to me because of the QDECREF(rule) for
the pop'ed rules.
Max
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 00/10] Provide a QOM-based authorization API, Daniel P. Berrange, 2016/03/07
- [Qemu-devel] [PATCH v2 03/10] qom: support arbitrary non-scalar properties with -object, Daniel P. Berrange, 2016/03/07
- [Qemu-devel] [PATCH v2 04/10] util: add QAuthZ object as an authorization base class, Daniel P. Berrange, 2016/03/07
- [Qemu-devel] [PATCH v2 02/10] qapi: allow QmpInputVisitor to auto-cast types, Daniel P. Berrange, 2016/03/07
- [Qemu-devel] [PATCH v2 05/10] util: add QAuthZSimple object type for a simple access control list, Daniel P. Berrange, 2016/03/07
- [Qemu-devel] [PATCH v2 06/10] acl: delete existing ACL implementation, Daniel P. Berrange, 2016/03/07
- [Qemu-devel] [PATCH v2 07/10] qemu-nbd: add support for ACLs for TLS clients, Daniel P. Berrange, 2016/03/07
- [Qemu-devel] [PATCH v2 08/10] nbd: allow an ACL to be set with nbd-server-start QMP command, Daniel P. Berrange, 2016/03/07
- [Qemu-devel] [PATCH v2 09/10] chardev: add support for ACLs for TLS clients, Daniel P. Berrange, 2016/03/07
- [Qemu-devel] [PATCH v2 10/10] vnc: allow specifying a custom ACL object name, Daniel P. Berrange, 2016/03/07