[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] postcopy: Remove the x-
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH 2/2] postcopy: Remove the x- |
Date: |
Wed, 9 Mar 2016 20:16:12 +0000 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
* Eric Blake (address@hidden) wrote:
> On 03/09/2016 12:50 PM, Dr. David Alan Gilbert (git) wrote:
> > From: "Dr. David Alan Gilbert" <address@hidden>
> >
> > Postcopy seems to have survived a cycle with only a few fixes,
> > and Jiri has the current libvirt wired up and working
> > ( https://www.redhat.com/archives/libvir-list/2016-March/msg00080.html )
> > so lets remove the experimental tag.
>
> s/lets/let's/ (in this case, you are contracting "let us")
Thanks.
> Does the balance of the universe stay the same by moving the apostrophe
> from 1/2 into this one? :)
Damn, you've figured out my scheme.
>
> >
> > Signed-off-by: Dr. David Alan Gilbert <address@hidden>
> > ---
>
> > +++ b/qapi-schema.json
> > @@ -540,7 +540,7 @@
> > # @auto-converge: If enabled, QEMU will automatically throttle down the
> > guest
> > # to speed up convergence of RAM migration. (since 1.6)
> > #
> > -# @x-postcopy-ram: Start executing on the migration target before all of
> > RAM has
> > +# @postcopy-ram: Start executing on the migration target before all of RAM
> > has
> > # been migrated, pulling the remaining pages along as needed.
> > NOTE: If
> > # the migration fails during postcopy the VM will fail. (since
> > 2.5)
>
> s/2.5/2.6/ - we want to advertise when the non-experimental name existed
> (compare to commit 6575ccdd dropping the x- from input-send-event).
>
> With that tweak,
> Reviewed-by: Eric Blake <address@hidden>
>
> --
> Eric Blake eblake redhat com +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK