[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.6 04/10] s390x/cpu: Tolerate max_cpus
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCH for-2.6 04/10] s390x/cpu: Tolerate max_cpus |
Date: |
Wed, 9 Mar 2016 22:55:30 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 |
On 09.03.2016 18:28, Cornelia Huck wrote:
> From: Matthew Rosato <address@hidden>
>
> Once hotplug is enabled, interrupts may come in for CPUs
> with an address > smp_cpus. Allocate for this and allow
> search routines to look beyond smp_cpus.
>
> Signed-off-by: Matthew Rosato <address@hidden>
> Message-Id: <address@hidden>
> Reviewed-by: David Hildenbrand <address@hidden>
> Signed-off-by: Cornelia Huck <address@hidden>
> ---
> hw/s390x/s390-virtio.c | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/hw/s390x/s390-virtio.c b/hw/s390x/s390-virtio.c
> index c501a48..57c3c88 100644
> --- a/hw/s390x/s390-virtio.c
> +++ b/hw/s390x/s390-virtio.c
...
> @@ -101,14 +102,14 @@ void s390_init_cpus(MachineState *machine)
> machine->cpu_model = "host";
> }
>
> - ipi_states = g_malloc(sizeof(S390CPU *) * smp_cpus);
> + cpu_states = g_malloc0(sizeof(S390CPU *) * max_cpus);
While you're at it, it might be better to use g_new0 here instead
(see e.g. https://patchwork.ozlabs.org/patch/517377/ for a description
why this is better).
Thomas
- [Qemu-devel] [PATCH for-2.6 00/10] s390x patches for 2.6, Cornelia Huck, 2016/03/09
- [Qemu-devel] [PATCH for-2.6 05/10] s390x/cpu: Add CPU property links, Cornelia Huck, 2016/03/09
- [Qemu-devel] [PATCH for-2.6 03/10] s390x/cpu: Get rid of side effects when creating a vcpu, Cornelia Huck, 2016/03/09
- [Qemu-devel] [PATCH for-2.6 02/10] s390x/cpu: Set initial CPU state in common routine, Cornelia Huck, 2016/03/09
- [Qemu-devel] [PATCH for-2.6 08/10] pc-bios/s390-ccw: fix old bug in ptr increment, Cornelia Huck, 2016/03/09
- [Qemu-devel] [PATCH for-2.6 07/10] s390x/cpu: Allow hotplug of CPUs, Cornelia Huck, 2016/03/09
- [Qemu-devel] [PATCH for-2.6 09/10] s390x: Introduce machine definition macros, Cornelia Huck, 2016/03/09
- [Qemu-devel] [PATCH for-2.6 06/10] s390x/cpu: Add error handling to cpu creation, Cornelia Huck, 2016/03/09
- [Qemu-devel] [PATCH for-2.6 01/10] s390x/cpu: Cleanup init in preparation for hotplug, Cornelia Huck, 2016/03/09
- [Qemu-devel] [PATCH for-2.6 04/10] s390x/cpu: Tolerate max_cpus, Cornelia Huck, 2016/03/09
- Re: [Qemu-devel] [PATCH for-2.6 04/10] s390x/cpu: Tolerate max_cpus,
Thomas Huth <=
- [Qemu-devel] [PATCH for-2.6 10/10] s390x: Introduce S390MachineClass, Cornelia Huck, 2016/03/09