[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/8] qdict: fix unbounded stack for qdict_array_
From: |
Peter Xu |
Subject: |
Re: [Qemu-devel] [PATCH 1/8] qdict: fix unbounded stack for qdict_array_entries |
Date: |
Thu, 10 Mar 2016 09:30:07 +0800 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Wed, Mar 09, 2016 at 10:03:51PM +0100, Markus Armbruster wrote:
> Kevin Wolf <address@hidden> writes:
> > I think it's unnecessary, but fine with me. I'm just trying to say that
> > making it a fixed 128 byte array on the stack certainly doesn't improve
> > anything.
>
> It trades a few bytes of stack for a fixed stack frame. A fixed stack
> frame is a bit more efficient (not that it matters here), and lets us
> scratch the function permanently from the list of stack fram size false
> positives. I think that's a reasonable trade.
Yes, that's what I want to do. I did fix nothing, but tried to avoid
the warning. Sorry that I made it a wrong title (also in the
following splitted patch). I should say:
"Fix unbounded stack warning for qdict_array_entries"
Rather than:
"Fix unbounded stack for qdict_array_entries"
Thanks.
Peter
- Re: [Qemu-devel] [PATCH 1/8] qdict: fix unbounded stack for qdict_array_entries, (continued)
- Re: [Qemu-devel] [PATCH 1/8] qdict: fix unbounded stack for qdict_array_entries, Peter Xu, 2016/03/08
- Re: [Qemu-devel] [PATCH 1/8] qdict: fix unbounded stack for qdict_array_entries, Eric Blake, 2016/03/08
- Re: [Qemu-devel] [PATCH 1/8] qdict: fix unbounded stack for qdict_array_entries, Peter Xu, 2016/03/08
- Re: [Qemu-devel] [PATCH 1/8] qdict: fix unbounded stack for qdict_array_entries, Kevin Wolf, 2016/03/09
- Re: [Qemu-devel] [PATCH 1/8] qdict: fix unbounded stack for qdict_array_entries, Markus Armbruster, 2016/03/09
- Re: [Qemu-devel] [PATCH 1/8] qdict: fix unbounded stack for qdict_array_entries, Kevin Wolf, 2016/03/09
- Re: [Qemu-devel] [PATCH 1/8] qdict: fix unbounded stack for qdict_array_entries, Markus Armbruster, 2016/03/09
- Re: [Qemu-devel] [PATCH 1/8] qdict: fix unbounded stack for qdict_array_entries,
Peter Xu <=
[Qemu-devel] [PATCH 2/8] block: fix unbounded stack for dump_qdict, Peter Xu, 2016/03/08
Re: [Qemu-devel] [PATCH 2/8] block: fix unbounded stack for dump_qdict, Peter Xu, 2016/03/08
Re: [Qemu-devel] [PATCH 2/8] block: fix unbounded stack for dump_qdict, Markus Armbruster, 2016/03/08
Re: [Qemu-devel] [PATCH 2/8] block: fix unbounded stack for dump_qdict, Paolo Bonzini, 2016/03/08
Re: [Qemu-devel] [PATCH 2/8] block: fix unbounded stack for dump_qdict, Peter Xu, 2016/03/08
[Qemu-devel] [PATCH 3/8] usb: fix unbounded stack for ohci_td_pkt, Peter Xu, 2016/03/08