[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 10/12] i.MX: Add the Freescale SPI Controller
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v3 10/12] i.MX: Add the Freescale SPI Controller |
Date: |
Thu, 10 Mar 2016 17:31:32 +0700 |
On 2 March 2016 at 05:27, Jean-Christophe Dubois <address@hidden> wrote:
> Signed-off-by: Jean-Christophe Dubois <address@hidden>
> ---
>
> +
> +static void imx_spi_reset(DeviceState *dev)
> +{
> + IMXSPIState *s = IMX_SPI(dev);
> + int i;
> +
> + DPRINTF("\n");
> +
> + memset(s->regs, 0, sizeof(s->regs));
> +
> + s->regs[ECSPI_STATREG] = 0x00000003;
> +
> + imx_spi_rxfifo_reset(s);
> + imx_spi_txfifo_reset(s);
> +
> + imx_spi_update_irq(s);
> +
> + s->burst_length = 0;
> +
> + for (i = 0; i < 4; i++) {
> + qemu_set_irq(s->cs_lines[i], 0);
> + }
Calling qemu_set_irq() from a reset function is generally
a bad idea.
> +}
Otherwise
Reviewed-by: Peter Maydell <address@hidden>
thanks
-- PMM
- [Qemu-devel] [PATCH v3 06/12] ARM: Factor out ARM on/off PSCI control functions, (continued)
- [Qemu-devel] [PATCH v3 06/12] ARM: Factor out ARM on/off PSCI control functions, Jean-Christophe Dubois, 2016/03/01
- [Qemu-devel] [PATCH v3 05/12] i.MX: Add i.MX6 CCM and ANALOG device., Jean-Christophe Dubois, 2016/03/01
- [Qemu-devel] [PATCH v3 09/12] FIFO: Add a FIFO32 implementation, Jean-Christophe Dubois, 2016/03/01
- [Qemu-devel] [PATCH v3 08/12] i.MX: Add missing descriptions in devices., Jean-Christophe Dubois, 2016/03/01
- [Qemu-devel] [PATCH v3 07/12] i.MX: Add i.MX6 System Reset Controller device., Jean-Christophe Dubois, 2016/03/01
- [Qemu-devel] [PATCH v3 10/12] i.MX: Add the Freescale SPI Controller, Jean-Christophe Dubois, 2016/03/01
- Re: [Qemu-devel] [PATCH v3 10/12] i.MX: Add the Freescale SPI Controller,
Peter Maydell <=
- [Qemu-devel] [PATCH v3 12/12] i.MX: Add sabrelite i.MX6 emulation., Jean-Christophe Dubois, 2016/03/01
- Re: [Qemu-devel] [PATCH v3 12/12] i.MX: Add sabrelite i.MX6 emulation., Peter Maydell, 2016/03/10
- Re: [Qemu-devel] [PATCH v3 12/12] i.MX: Add sabrelite i.MX6 emulation., Jean-Christophe DUBOIS, 2016/03/10
- Re: [Qemu-devel] [PATCH v3 12/12] i.MX: Add sabrelite i.MX6 emulation., Peter Maydell, 2016/03/10
- Re: [Qemu-devel] [PATCH v3 12/12] i.MX: Add sabrelite i.MX6 emulation., Jean-Christophe DUBOIS, 2016/03/15
- Re: [Qemu-devel] [PATCH v3 12/12] i.MX: Add sabrelite i.MX6 emulation., Peter Maydell, 2016/03/16
- Re: [Qemu-devel] [PATCH v3 12/12] i.MX: Add sabrelite i.MX6 emulation., Peter Maydell, 2016/03/16
[Qemu-devel] [PATCH v3 11/12] i.MX: Add i.MX6 SOC implementation., Jean-Christophe Dubois, 2016/03/01