[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 2/5] icount: remove obsolete warp call
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v4 2/5] icount: remove obsolete warp call |
Date: |
Thu, 10 Mar 2016 13:11:08 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 |
On 10/03/2016 12:56, Pavel Dovgalyuk wrote:
> qemu_clock_warp call in qemu_tcg_wait_io_event function is not needed
> anymore, because it is called in every iteration of main_loop_wait.
>
> Reviewed-by: Paolo Bonzini <address@hidden>
> Signed-off-by: Pavel Dovgalyuk <address@hidden>
Thanks again. These two patches make the icount mechanism much easier
to understand.
Paolo
> ---
> cpus.c | 3 ---
> 1 files changed, 0 insertions(+), 3 deletions(-)
>
> diff --git a/cpus.c b/cpus.c
> index bc774e2..85d0f87 100644
> --- a/cpus.c
> +++ b/cpus.c
> @@ -995,9 +995,6 @@ static void qemu_wait_io_event_common(CPUState *cpu)
> static void qemu_tcg_wait_io_event(CPUState *cpu)
> {
> while (all_cpu_threads_idle()) {
> - /* Start accounting real time to the virtual clock if the CPUs
> - are idle. */
> - qemu_clock_warp(QEMU_CLOCK_VIRTUAL);
> qemu_cond_wait(cpu->halt_cond, &qemu_global_mutex);
> }
>
>
[Qemu-devel] [PATCH v4 4/5] block: add flush callback, Pavel Dovgalyuk, 2016/03/10
[Qemu-devel] [PATCH v4 5/5] replay: introduce block devices record/replay, Pavel Dovgalyuk, 2016/03/10