[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 01/21] osdep: fix socket_error() to work with
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] [PATCH v1 01/21] osdep: fix socket_error() to work with Mingw64 |
Date: |
Thu, 10 Mar 2016 16:13:17 +0000 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Thu, Mar 10, 2016 at 05:12:36PM +0100, Paolo Bonzini wrote:
>
>
> On 09/03/2016 18:28, Daniel P. Berrange wrote:
> > + case WSAEWOULDBLOCK:
> > + return EWOULDBLOCK;
>
> On mingw EAGAIN != EWOULDBLOCK. Can you instead return EAGAIN here, so
> that we can get rid of the "... || errno == EWOULDBLOCK" everywhere?
Oh yes, that's a good idea.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
- [Qemu-devel] [PATCH v1 00/21] Multiple fixes & improves to QIOChannel & Win32, Daniel P. Berrange, 2016/03/09
- [Qemu-devel] [PATCH v1 02/21] io: use bind() to check for IPv4/6 availability, Daniel P. Berrange, 2016/03/09
- [Qemu-devel] [PATCH v1 03/21] io: initialize sockets in test program, Daniel P. Berrange, 2016/03/09
- [Qemu-devel] [PATCH v1 01/21] osdep: fix socket_error() to work with Mingw64, Daniel P. Berrange, 2016/03/09
- [Qemu-devel] [PATCH v1 04/21] io: bind to socket before creating QIOChannelSocket, Daniel P. Berrange, 2016/03/09
- [Qemu-devel] [PATCH v1 05/21] io: wait for incoming client in socket test, Daniel P. Berrange, 2016/03/09
- [Qemu-devel] [PATCH v1 06/21] io: set correct error object in background reader test thread, Daniel P. Berrange, 2016/03/09
- [Qemu-devel] [PATCH v1 07/21] io: assert errors before asserting content in I/O test, Daniel P. Berrange, 2016/03/09
- [Qemu-devel] [PATCH v1 08/21] io: fix copy+paste mistake in socket error message, Daniel P. Berrange, 2016/03/09
- [Qemu-devel] [PATCH v1 09/21] io: add missing EWOULDBLOCK checks in Win32 I/O code paths, Daniel P. Berrange, 2016/03/09
- [Qemu-devel] [PATCH v1 10/21] io: pass HANDLE to g_source_add_poll on Win32, Daniel P. Berrange, 2016/03/09
- [Qemu-devel] [PATCH v1 11/21] io: introduce qio_channel_create_socket_watch, Daniel P. Berrange, 2016/03/09
- [Qemu-devel] [PATCH v1 12/21] io: implement socket watch for win32 using WSAEventSelect+select, Daniel P. Berrange, 2016/03/09