[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Replaced get_ticks_per_sec calls with NANOSECON
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH] Replaced get_ticks_per_sec calls with NANOSECONDS_PER_SECOND |
Date: |
Thu, 10 Mar 2016 18:28:51 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 |
On 10/03/2016 18:22, rutuja shah wrote:
> Hi,
> As there are no callers to get_ticks_per_sec() function, definition of
> this function could be removed completely?
Yes, please.
> diff --git a/backends/baum.c b/backends/baum.c
> index c11320e..20b49f2 100644
> --- a/backends/baum.c
> +++ b/backends/baum.c
> @@ -336,7 +336,7 @@ static int baum_eat_packet(BaumDriverState *baum,
> const uint8_t *buf, int len)
>
> /* Allow 100ms to complete the DisplayData packet */
> timer_mod(baum->cellCount_timer,
> qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL) +
> - get_ticks_per_sec() / 10);
> + NANOSECONDS_PER_SECOND / 10);
There is a problem with your patch, probably because you're using gmail;
lines are wrapped (for example the timer_mod line shows as two lines).
You can use the smtp.gmail.com server and git-send-email to avoid this
issue.
Thanks,
Paolo