[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 07/15] HBitmap: Introduce "meta" bitmap to tr
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [PATCH v4 07/15] HBitmap: Introduce "meta" bitmap to track bit changes |
Date: |
Fri, 11 Mar 2016 15:48:49 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 |
On 08.03.2016 05:44, Fam Zheng wrote:
> Upon each bit toggle, the corresponding bit in the meta bitmap will be
> set.
>
> Signed-off-by: Fam Zheng <address@hidden>
> Reviewed-by: John Snow <address@hidden>
> ---
> block/dirty-bitmap.c | 2 +-
> include/qemu/hbitmap.h | 17 +++++++++++++
> util/hbitmap.c | 66
> ++++++++++++++++++++++++++++++++++++++------------
> 3 files changed, 69 insertions(+), 16 deletions(-)
>
> diff --git a/block/dirty-bitmap.c b/block/dirty-bitmap.c
> index 16f73b2..0a188f2 100644
> --- a/block/dirty-bitmap.c
> +++ b/block/dirty-bitmap.c
> @@ -231,7 +231,7 @@ static void
> bdrv_do_release_matching_dirty_bitmap(BlockDriverState *bs,
> BdrvDirtyBitmap *bm, *next;
> QLIST_FOREACH_SAFE(bm, &bs->dirty_bitmaps, list, next) {
> if ((!bitmap || bm == bitmap) && (!only_named || bm->name)) {
> - assert(!bitmap->active_iterators);
> + assert(!bm->active_iterators);
I guess this should be squashed into patch 6. Good point, by the way,
yes, using bitmap is wrong here. :-)
Max
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v4 00/15] Dirty bitmap changes for migration/persistence work, Fam Zheng, 2016/03/07
- [Qemu-devel] [PATCH v4 01/15] backup: Use Bitmap to replace "s->bitmap", Fam Zheng, 2016/03/07
- [Qemu-devel] [PATCH v4 02/15] block: Include hbitmap.h in block.h, Fam Zheng, 2016/03/07
- [Qemu-devel] [PATCH v4 03/15] typedefs: Add BdrvDirtyBitmap, Fam Zheng, 2016/03/07
- [Qemu-devel] [PATCH v4 05/15] block: Remove unused typedef of BlockDriverDirtyHandler, Fam Zheng, 2016/03/07
- [Qemu-devel] [PATCH v4 04/15] block: Move block dirty bitmap code to separate files, Fam Zheng, 2016/03/07
- [Qemu-devel] [PATCH v4 06/15] block: Hide HBitmap in block dirty bitmap interface, Fam Zheng, 2016/03/07
- [Qemu-devel] [PATCH v4 07/15] HBitmap: Introduce "meta" bitmap to track bit changes, Fam Zheng, 2016/03/07
- Re: [Qemu-devel] [PATCH v4 07/15] HBitmap: Introduce "meta" bitmap to track bit changes,
Max Reitz <=
- [Qemu-devel] [PATCH v4 08/15] tests: Add test code for meta bitmap, Fam Zheng, 2016/03/07
- [Qemu-devel] [PATCH v4 09/15] block: Support meta dirty bitmap, Fam Zheng, 2016/03/07
- [Qemu-devel] [PATCH v4 10/15] block: Add two dirty bitmap getters, Fam Zheng, 2016/03/07
- [Qemu-devel] [PATCH v4 11/15] block: Assert that bdrv_release_dirty_bitmap succeeded, Fam Zheng, 2016/03/07
- [Qemu-devel] [PATCH v4 12/15] hbitmap: serialization, Fam Zheng, 2016/03/07