[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 05/13] docker: Add common.rc
From: |
Alex Bennée |
Subject: |
Re: [Qemu-devel] [PATCH v3 05/13] docker: Add common.rc |
Date: |
Fri, 11 Mar 2016 16:06:55 +0000 |
User-agent: |
mu4e 0.9.17; emacs 25.0.92.3 |
Fam Zheng <address@hidden> writes:
> "requires" checks the "FEATURE" environment for specified prerequisits,
> and skip the execution of test if not found.
You also add a build_qemu function which you should mention.
Otherwise have a:
Reviewed-by: Alex Bennée <address@hidden>
>
> Signed-off-by: Fam Zheng <address@hidden>
> ---
> tests/docker/common.rc | 31 +++++++++++++++++++++++++++++++
> 1 file changed, 31 insertions(+)
> create mode 100755 tests/docker/common.rc
>
> diff --git a/tests/docker/common.rc b/tests/docker/common.rc
> new file mode 100755
> index 0000000..74b89d6
> --- /dev/null
> +++ b/tests/docker/common.rc
> @@ -0,0 +1,31 @@
> +#!/bin/sh
> +#
> +# Common routines for docker test scripts.
> +#
> +# Copyright (c) 2016 Red Hat Inc.
> +#
> +# Authors:
> +# Fam Zheng <address@hidden>
> +#
> +# This work is licensed under the terms of the GNU GPL, version 2
> +# or (at your option) any later version. See the COPYING file in
> +# the top-level directory.
> +
> +requires()
> +{
> + for c in $@; do
> + if ! echo "$FEATURES" | grep -wq -e "$c"; then
> + echo "Prerequisite '$c' not present, skip"
> + exit 0
> + fi
> + done
> +}
> +
> +build_qemu()
> +{
> + $QEMU_SRC/configure \
> + --target-list="${TARGET_LIST}" \
> + --prefix="$PWD/install" \
> + "$@"
> + make $MAKEFLAGS
> +}
--
Alex Bennée
- Re: [Qemu-devel] [PATCH v3 01/13] tests: Add utilities for docker testing, (continued)
- [Qemu-devel] [PATCH v3 02/13] Makefile: Rules for docker testing, Fam Zheng, 2016/03/04
- [Qemu-devel] [PATCH v3 03/13] docker: Add images, Fam Zheng, 2016/03/04
- [Qemu-devel] [PATCH v3 04/13] docker: Add test runner, Fam Zheng, 2016/03/04
- [Qemu-devel] [PATCH v3 05/13] docker: Add common.rc, Fam Zheng, 2016/03/04
- Re: [Qemu-devel] [PATCH v3 05/13] docker: Add common.rc,
Alex Bennée <=
- [Qemu-devel] [PATCH v3 06/13] docker: Add quick test, Fam Zheng, 2016/03/04
- [Qemu-devel] [PATCH v3 07/13] docker: Add full test, Fam Zheng, 2016/03/04
- [Qemu-devel] [PATCH v3 08/13] docker: Add clang test, Fam Zheng, 2016/03/04
- [Qemu-devel] [PATCH v3 09/13] docker: Add mingw test, Fam Zheng, 2016/03/04