[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v4 19/28] migration: delete QEMUFile buffer implemen
From: |
Daniel P. Berrange |
Subject: |
[Qemu-devel] [PATCH v4 19/28] migration: delete QEMUFile buffer implementation |
Date: |
Fri, 11 Mar 2016 16:37:53 +0000 |
The qemu_bufopen() method is no longer used, so the memory
buffer based QEMUFile backend can be deleted entirely.
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Signed-off-by: Daniel P. Berrange <address@hidden>
---
include/migration/qemu-file.h | 6 ---
migration/qemu-file-buf.c | 96 -------------------------------------------
2 files changed, 102 deletions(-)
diff --git a/include/migration/qemu-file.h b/include/migration/qemu-file.h
index 0329ccc..6618d19 100644
--- a/include/migration/qemu-file.h
+++ b/include/migration/qemu-file.h
@@ -140,7 +140,6 @@ QEMUFile *qemu_fopen_socket(int fd, const char *mode);
QEMUFile *qemu_fopen_channel_input(QIOChannel *ioc);
QEMUFile *qemu_fopen_channel_output(QIOChannel *ioc);
QEMUFile *qemu_popen_cmd(const char *command, const char *mode);
-QEMUFile *qemu_bufopen(const char *mode, QEMUSizedBuffer *input);
void qemu_file_set_hooks(QEMUFile *f, const QEMUFileHooks *hooks);
int qemu_get_fd(QEMUFile *f);
int qemu_fclose(QEMUFile *f);
@@ -166,11 +165,6 @@ ssize_t qsb_write_at(QEMUSizedBuffer *qsb, const uint8_t
*buf,
off_t pos, size_t count);
-/*
- * For use on files opened with qemu_bufopen
- */
-const QEMUSizedBuffer *qemu_buf_get(QEMUFile *f);
-
static inline void qemu_put_ubyte(QEMUFile *f, unsigned int v)
{
qemu_put_byte(f, (int)v);
diff --git a/migration/qemu-file-buf.c b/migration/qemu-file-buf.c
index 7b8e78e..668ab35 100644
--- a/migration/qemu-file-buf.c
+++ b/migration/qemu-file-buf.c
@@ -366,99 +366,3 @@ ssize_t qsb_write_at(QEMUSizedBuffer *qsb, const uint8_t
*source,
return count;
}
-
-typedef struct QEMUBuffer {
- QEMUSizedBuffer *qsb;
- QEMUFile *file;
- bool qsb_allocated;
-} QEMUBuffer;
-
-static ssize_t buf_get_buffer(void *opaque, uint8_t *buf, int64_t pos,
- size_t size)
-{
- QEMUBuffer *s = opaque;
- ssize_t len = qsb_get_length(s->qsb) - pos;
-
- if (len <= 0) {
- return 0;
- }
-
- if (len > size) {
- len = size;
- }
- return qsb_get_buffer(s->qsb, pos, len, buf);
-}
-
-static ssize_t buf_put_buffer(void *opaque, const uint8_t *buf,
- int64_t pos, size_t size)
-{
- QEMUBuffer *s = opaque;
-
- return qsb_write_at(s->qsb, buf, pos, size);
-}
-
-static int buf_close(void *opaque)
-{
- QEMUBuffer *s = opaque;
-
- if (s->qsb_allocated) {
- qsb_free(s->qsb);
- }
-
- g_free(s);
-
- return 0;
-}
-
-const QEMUSizedBuffer *qemu_buf_get(QEMUFile *f)
-{
- QEMUBuffer *p;
-
- qemu_fflush(f);
-
- p = f->opaque;
-
- return p->qsb;
-}
-
-static const QEMUFileOps buf_read_ops = {
- .get_buffer = buf_get_buffer,
- .close = buf_close,
-};
-
-static const QEMUFileOps buf_write_ops = {
- .put_buffer = buf_put_buffer,
- .close = buf_close,
-};
-
-QEMUFile *qemu_bufopen(const char *mode, QEMUSizedBuffer *input)
-{
- QEMUBuffer *s;
-
- if (mode == NULL || (mode[0] != 'r' && mode[0] != 'w') ||
- mode[1] != '\0') {
- error_report("qemu_bufopen: Argument validity check failed");
- return NULL;
- }
-
- s = g_new0(QEMUBuffer, 1);
- s->qsb = input;
-
- if (s->qsb == NULL) {
- s->qsb = qsb_create(NULL, 0);
- s->qsb_allocated = true;
- }
- if (!s->qsb) {
- g_free(s);
- error_report("qemu_bufopen: qsb_create failed");
- return NULL;
- }
-
-
- if (mode[0] == 'r') {
- s->file = qemu_fopen_ops(s, &buf_read_ops);
- } else {
- s->file = qemu_fopen_ops(s, &buf_write_ops);
- }
- return s->file;
-}
--
2.5.0
- Re: [Qemu-devel] [PATCH v4 10/28] migration: add reporting of errors for outgoing migration, (continued)
- [Qemu-devel] [PATCH v4 11/28] migration: convert post-copy to use QIOChannelBuffer, Daniel P. Berrange, 2016/03/11
- [Qemu-devel] [PATCH v4 09/28] migration: add helpers for creating QEMUFile from a QIOChannel, Daniel P. Berrange, 2016/03/11
- [Qemu-devel] [PATCH v4 12/28] migration: convert unix socket protocol to use QIOChannel, Daniel P. Berrange, 2016/03/11
- [Qemu-devel] [PATCH v4 13/28] migration: rename unix.c to socket.c, Daniel P. Berrange, 2016/03/11
- [Qemu-devel] [PATCH v4 14/28] migration: convert tcp socket protocol to use QIOChannel, Daniel P. Berrange, 2016/03/11
- [Qemu-devel] [PATCH v4 18/28] migration: convert savevm to use QIOChannel for writing to files, Daniel P. Berrange, 2016/03/11
- [Qemu-devel] [PATCH v4 16/28] migration: convert exec socket protocol to use QIOChannel, Daniel P. Berrange, 2016/03/11
- [Qemu-devel] [PATCH v4 15/28] migration: convert fd socket protocol to use QIOChannel, Daniel P. Berrange, 2016/03/11
- [Qemu-devel] [PATCH v4 19/28] migration: delete QEMUFile buffer implementation,
Daniel P. Berrange <=
- [Qemu-devel] [PATCH v4 22/28] migration: delete QEMUFile stdio implementation, Daniel P. Berrange, 2016/03/11
- [Qemu-devel] [PATCH v4 24/28] migration: don't use an array for storing migrate parameters, Daniel P. Berrange, 2016/03/11
- [Qemu-devel] [PATCH v4 20/28] migration: delete QEMUSizedBuffer struct, Daniel P. Berrange, 2016/03/11
- [Qemu-devel] [PATCH v4 21/28] migration: delete QEMUFile sockets implementation, Daniel P. Berrange, 2016/03/11
- [Qemu-devel] [PATCH v4 23/28] migration: move definition of struct QEMUFile back into qemu-file.c, Daniel P. Berrange, 2016/03/11
- [Qemu-devel] [PATCH v4 25/28] migration: define 'tls-creds' and 'tls-hostname' migration parameters, Daniel P. Berrange, 2016/03/11
- [Qemu-devel] [PATCH v4 28/28] migration: remove qemu_get_fd method from QEMUFile, Daniel P. Berrange, 2016/03/11
- [Qemu-devel] [PATCH v4 17/28] migration: convert RDMA to use QIOChannel interface, Daniel P. Berrange, 2016/03/11
- [Qemu-devel] [PATCH v4 27/28] migration: remove support for non-iovec based write handlers, Daniel P. Berrange, 2016/03/11