[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 0/4] Implement some QKeyCode support
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v4 0/4] Implement some QKeyCode support |
Date: |
Fri, 11 Mar 2016 10:14:16 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 |
On 03/10/2016 07:24 PM, Programmingkid wrote:
> This patchset adds QKeyCode support the adb and cocoa code.
>
> Note: you do not need to be on a Mac to test out the adb.c, qapi-schema.json,
> and adb-keys.h files. Only the cocoa.m file changes are Mac specific.
>
> If you are using Linux as a guest, then the xev command is what you could use
> to
> test out these patches. For a Mac OS guest the Key Caps application would help
> with testing out these patches.
>
> John Arbuckle (4):
> cocoa.m
> qapi-schema.json
> adb-keys.h
> adb.c
This isn't the typical git cover letter - git lists the titles of the
four patches, not the basenames of the files modified by the patches.
Also, you still didn't manage to get threading quite right; the series
ended up as 5 top-level threads, which makes it harder to find things in
mailers that sort by threads with most recent activity.
>
> hw/input/adb.c | 223 ++++++++++++++++++++++++-------
> include/hw/input/adb-keys.h | 146 ++++++++++++++++++++
> qapi-schema.json | 3 +-
> ui/cocoa.m | 317
> ++++++++++++++++++++------------------------
> 4 files changed, 466 insertions(+), 223 deletions(-)
> create mode 100644 include/hw/input/adb-keys.h
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature