|
From: | Changlong Xie |
Subject: | Re: [Qemu-devel] [PATCH] quorum: Fix crash in quorum_aio_cb() |
Date: | Mon, 14 Mar 2016 09:57:31 +0800 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 |
On 03/11/2016 04:25 PM, Alberto Garcia wrote:
On Fri 11 Mar 2016 02:31:31 AM CET, Wen Congyang wrote:On 03/10/2016 08:13 PM, Alberto Garcia wrote:quorum_aio_cb() emits the QUORUM_REPORT_BAD event if there's an I/O error in a Quorum child. However sacb->aiocb must be correctly initialized for this to happen. read_quorum_children() and read_fifo_child() are not doing this, which results in a QEMU crash.If we use FIFO mode, we don't call quorum_report_bad() in quorum_aio_cb(). But it is OK to iniialize sacb->aiocb for it.
Hi betro
You're right. I still think it's a good idea to leave it initialized in case we change that in the future.
Yes.
And now that we're at it, shouldn't we call quorum_report_bad() in FIFO mode as well? Or is there any reason not to do it?
IMO, no reason not to do it. Thanks -Xie
Berto
[Prev in Thread] | Current Thread | [Next in Thread] |