[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC] [tcg] Idea on refactoring target code generation
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [RFC] [tcg] Idea on refactoring target code generation loop (gen_intermediate_code) |
Date: |
Mon, 14 Mar 2016 15:14:59 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 |
On 14/03/2016 13:23, KONRAD Frederic wrote:
>> These "target-specific hooks" probably ought not be "hooks" in the
>> traditional sense of attaching them to CPUState. I'd be more
>> comfortable with a refactoring that used include files -- maybe .h or
>> maybe .inc.c. If we do the normal sort of hook, then we've got to
>> either expose DisasContext in places we shouldn't, or dynamically
>> allocate it. Neither seems particularly appealing.
>
> On the other side I think attaching them to CPUState would make
> heterogenous system emulation easier?
It depends on whether they're going to be called from generic code. As
long as they are only called from other CPU-specific bits, adding them
to CPUState isn't necessary.
Paolo
- Re: [Qemu-devel] [RFC] [tcg] Idea on refactoring target code generation loop (gen_intermediate_code), (continued)
- Re: [Qemu-devel] [RFC] [tcg] Idea on refactoring target code generation loop (gen_intermediate_code), Richard Henderson, 2016/03/09
- Re: [Qemu-devel] [RFC] [tcg] Idea on refactoring target code generation loop (gen_intermediate_code), Lluís Vilanova, 2016/03/09
- Re: [Qemu-devel] [RFC] [tcg] Idea on refactoring target code generation loop (gen_intermediate_code), Richard Henderson, 2016/03/09
- Re: [Qemu-devel] [RFC] [tcg] Idea on refactoring target code generation loop (gen_intermediate_code), Lluís Vilanova, 2016/03/09
- Re: [Qemu-devel] [RFC] [tcg] Idea on refactoring target code generation loop (gen_intermediate_code), Peter Maydell, 2016/03/09
- Re: [Qemu-devel] [RFC] [tcg] Idea on refactoring target code generation loop (gen_intermediate_code), Lluís Vilanova, 2016/03/13
- Re: [Qemu-devel] [RFC] [tcg] Idea on refactoring target code generation loop (gen_intermediate_code), Peter Maydell, 2016/03/13
- Re: [Qemu-devel] [RFC] [tcg] Idea on refactoring target code generation loop (gen_intermediate_code), Markus Armbruster, 2016/03/14
- Re: [Qemu-devel] [RFC] [tcg] Idea on refactoring target code generation loop (gen_intermediate_code), Lluís Vilanova, 2016/03/14
Re: [Qemu-devel] [RFC] [tcg] Idea on refactoring target code generation loop (gen_intermediate_code), KONRAD Frederic, 2016/03/14