[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/9] qemu-log: fix cpu_reset log target
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 2/9] qemu-log: fix cpu_reset log target |
Date: |
Mon, 14 Mar 2016 15:24:49 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 |
On 14/03/2016 12:21, Denis V. Lunev wrote:
> From: Vladimir Sementsov-Ogievskiy <address@hidden>
>
> Do not print superfluous zero cpu state on vm start with -d cpu_reset
It's really just the very first reset that is all zeroes. If you
use "-S", you can be in prelaunch state and have a meaningful state.
Overall I'm not sure that this patch provides a big benefit, but
I'll defer to Andreas and others that may want to chime in.
Paolo
> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> Signed-off-by: Denis V. Lunev <address@hidden>
> CC: Stefan Hajnoczi <address@hidden>
> CC: Paolo Bonzini <address@hidden>
> CC: Andreas Färber <address@hidden>
> ---
> qom/cpu.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/qom/cpu.c b/qom/cpu.c
> index c45d0bb..69e3b87 100644
> --- a/qom/cpu.c
> +++ b/qom/cpu.c
> @@ -247,7 +247,8 @@ static void cpu_common_reset(CPUState *cpu)
> {
> CPUClass *cc = CPU_GET_CLASS(cpu);
>
> - if (qemu_loglevel_mask(CPU_LOG_RESET)) {
> + if (qemu_loglevel_mask(CPU_LOG_RESET) &&
> + !runstate_check(RUN_STATE_PRELAUNCH)) {
> qemu_log("CPU Reset (CPU %d)\n", cpu->cpu_index);
> log_cpu_state(cpu, cc->reset_dump_flags);
> }
>
- [Qemu-devel] [PATCH v2 0/9] log: assorted improvements, Denis V. Lunev, 2016/03/14
- [Qemu-devel] [PATCH 4/9] log: move qemu_log_close/qemu_log_flush from header to log.c, Denis V. Lunev, 2016/03/14
- [Qemu-devel] [PATCH 5/9] log: improve performance of qemu_log and qemu_log_mask if disabled, Denis V. Lunev, 2016/03/14
- [Qemu-devel] [PATCH 3/9] log: improve code in do_qemu_set_log, Denis V. Lunev, 2016/03/14
- [Qemu-devel] [PATCH 2/9] qemu-log: fix cpu_reset log target, Denis V. Lunev, 2016/03/14
- Re: [Qemu-devel] [PATCH 2/9] qemu-log: fix cpu_reset log target,
Paolo Bonzini <=
- [Qemu-devel] [PATCH 1/9] trace: do not always call exit() in trace_enable_events, Denis V. Lunev, 2016/03/14
- [Qemu-devel] [PATCH 6/9] log: log QMP commands and replies, Denis V. Lunev, 2016/03/14
- Re: [Qemu-devel] [PATCH 6/9] log: log QMP commands and replies, Paolo Bonzini, 2016/03/14
- Re: [Qemu-devel] [PATCH 6/9] log: log QMP commands and replies, Daniel P. Berrange, 2016/03/14
- Re: [Qemu-devel] [PATCH 6/9] log: log QMP commands and replies, Denis V. Lunev, 2016/03/14
- Re: [Qemu-devel] [PATCH 6/9] log: log QMP commands and replies, Daniel P. Berrange, 2016/03/14
- Re: [Qemu-devel] [PATCH 6/9] log: log QMP commands and replies, Denis V. Lunev, 2016/03/14
- Re: [Qemu-devel] [PATCH 6/9] log: log QMP commands and replies, Paolo Bonzini, 2016/03/14
- Re: [Qemu-devel] [PATCH 6/9] log: log QMP commands and replies, Daniel P. Berrange, 2016/03/14