[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 8/9] log: report QAPI event
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 8/9] log: report QAPI event |
Date: |
Mon, 14 Mar 2016 15:33:46 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 |
On 14/03/2016 12:21, Denis V. Lunev wrote:
> From: Pavel Butsykin <address@hidden>
>
> Signed-off-by: Pavel Butsykin <address@hidden>
> Signed-off-by: Denis V. Lunev <address@hidden>
> CC: Stefan Hajnoczi <address@hidden>
> CC: Paolo Bonzini <address@hidden>
> CC: Luiz Capitulino <address@hidden>
> CC: Markus Armbruster <address@hidden>
> ---
> include/qemu/log.h | 1 +
> monitor.c | 6 ++++++
> util/log.c | 2 ++
> 3 files changed, 9 insertions(+)
>
> diff --git a/include/qemu/log.h b/include/qemu/log.h
> index 9264bbf..0c7a564 100644
> --- a/include/qemu/log.h
> +++ b/include/qemu/log.h
> @@ -44,6 +44,7 @@ static inline bool qemu_log_separate(void)
> #define LOG_TRACE (1 << 15)
> #define LOG_QMP (1 << 16)
> #define LOG_HMP (1 << 17)
> +#define LOG_QAPI (1 << 18)
This should just reuse LOG_QMP (but see reply to patch 6).
Paolo
> /* Returns true if a bit is set in the current loglevel mask
> */
> diff --git a/monitor.c b/monitor.c
> index 4bf4f31..751e754 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -467,6 +467,12 @@ static void monitor_qapi_event_emit(QAPIEvent event,
> QDict *qdict)
> {
> Monitor *mon;
>
> + if (qemu_loglevel_mask(LOG_QAPI)) {
> + QString *output_json = qobject_to_json(QOBJECT(qdict));
> + qemu_log_mask(LOG_QAPI, "QAPI event: %s\n", output_json->string);
> + QDECREF(output_json);
> + }
> +
> trace_monitor_protocol_event_emit(event, qdict);
> QLIST_FOREACH(mon, &mon_list, entry) {
> if (monitor_is_qmp(mon) && mon->qmp.in_command_mode) {
> diff --git a/util/log.c b/util/log.c
> index 795aaea..572f005 100644
> --- a/util/log.c
> +++ b/util/log.c
> @@ -135,6 +135,8 @@ const QEMULogItem qemu_log_items[] = {
> "log the QMP commands and events" },
> { LOG_HMP, "hmp",
> "log the HMP commands and events" },
> + { LOG_QAPI, "qapi",
> + "log the QAPI events"},
> { 0, NULL, NULL },
> };
>
>
[Qemu-devel] [PATCH 7/9] log: report HMP command and event, Denis V. Lunev, 2016/03/14
[Qemu-devel] [PATCH 9/9] log: adds a timestamp to each log entry, Denis V. Lunev, 2016/03/14
[Qemu-devel] [PATCH 8/9] log: report QAPI event, Denis V. Lunev, 2016/03/14
- Re: [Qemu-devel] [PATCH 8/9] log: report QAPI event,
Paolo Bonzini <=