[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Patch v2 1/1] blizzard: Remove support for DEPTH != 32
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [Patch v2 1/1] blizzard: Remove support for DEPTH != 32 |
Date: |
Mon, 14 Mar 2016 15:22:08 +0000 |
On 14 March 2016 at 15:04, Pooja Dhannawat <address@hidden> wrote:
> Removing support for DEPTH != 32 from blizzard template header
> and file that includes it, as macro DEPTH == 32 only used.
>
> Signed-off-by: Pooja Dhannawat <address@hidden>
> ---
> hw/display/blizzard.c | 24 ------------------------
> hw/display/blizzard_template.h | 30 +-----------------------------
> 2 files changed, 1 insertion(+), 53 deletions(-)
> @@ -956,22 +948,6 @@ void *s1d13745_init(qemu_irq gpio_int)
> s->line_fn_tab[0] = s->line_fn_tab[1] =
> g_malloc0(sizeof(blizzard_fn_t) * 0x10);
> break;
> - case 8:
> - s->line_fn_tab[0] = blizzard_draw_fn_8;
> - s->line_fn_tab[1] = blizzard_draw_fn_r_8;
> - break;
> - case 15:
> - s->line_fn_tab[0] = blizzard_draw_fn_15;
> - s->line_fn_tab[1] = blizzard_draw_fn_r_15;
> - break;
> - case 16:
> - s->line_fn_tab[0] = blizzard_draw_fn_16;
> - s->line_fn_tab[1] = blizzard_draw_fn_r_16;
> - break;
> - case 24:
> - s->line_fn_tab[0] = blizzard_draw_fn_24;
> - s->line_fn_tab[1] = blizzard_draw_fn_r_24;
> - break;
> case 32:
> s->line_fn_tab[0] = blizzard_draw_fn_32;
> s->line_fn_tab[1] = blizzard_draw_fn_r_32;
So are there any cases now when
surface_bits_per_pixel(qemu_console_surface(c)) can return
zero? (I don't understand the 'case 0' code in this switch
at all...)
thanks
-- PMM