[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Added NULL check for qemu_find_file()
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH] Added NULL check for qemu_find_file() |
Date: |
Mon, 14 Mar 2016 09:34:39 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 |
On 03/12/2016 01:36 PM, address@hidden wrote:
> From: Rutuja Shah <address@hidden>
>
> This patch adds NULL check for return value from qemu_find_file(), where it
> is missing. It avoids unnecessary function calls with NULL parameter which in
> turn return -1. Especially, incase of load_uimage(), two functions are called
> which return -1 on passing NULL
Please wrap your commit messages at 70 or so columns (since 'git log'
will display your text with indentation, and many people still prefer
80-column terminal windows).
s/incase/in case/
> ---
> hw/ppc/e500.c | 17 +++++++++++++----
> hw/sparc/leon3.c | 6 +++++-
> 2 files changed, 18 insertions(+), 5 deletions(-)
>
>
> Signed-off-by: Rutuja Shah <address@hidden>
This S-o-b is in the wrong place; it needs to appear before the ---
separator to be included in the git log after a maintainer does 'git am'
on your patch.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
Re: [Qemu-devel] [PATCH] Added NULL check for qemu_find_file(),
Eric Blake <=