[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 1/1] socket: Allocating Large sized arrays to hea
From: |
Pooja Dhannawat |
Subject: |
[Qemu-devel] [PATCH v2 1/1] socket: Allocating Large sized arrays to heap |
Date: |
Mon, 14 Mar 2016 22:07:53 +0530 |
net_socket_send has a huge stack usage of 69712 bytes approx.
Moving large arrays to heap to reduce stack usage.
Signed-off-by: Pooja Dhannawat <address@hidden>
---
net/socket.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/net/socket.c b/net/socket.c
index e32e3cb..3fcd7a6 100644
--- a/net/socket.c
+++ b/net/socket.c
@@ -147,10 +147,10 @@ static void net_socket_send(void *opaque)
NetSocketState *s = opaque;
int size, err;
unsigned l;
- uint8_t buf1[NET_BUFSIZE];
+ uint8_t *buf1 = g_new(uint8_t, NET_BUFSIZE);
const uint8_t *buf;
- size = qemu_recv(s->fd, buf1, sizeof(buf1), 0);
+ size = qemu_recv(s->fd, (uint8_t *)buf1, sizeof(uint8_t), 0);
if (size < 0) {
err = socket_error();
if (err != EWOULDBLOCK)
@@ -170,8 +170,8 @@ static void net_socket_send(void *opaque)
s->index = 0;
s->packet_len = 0;
s->nc.link_down = true;
- memset(s->buf, 0, sizeof(s->buf));
memset(s->nc.info_str, 0, sizeof(s->nc.info_str));
+ g_free(buf1);
return;
}
@@ -222,6 +222,8 @@ static void net_socket_send(void *opaque)
break;
}
}
+
+ g_free(buf1);
}
static void net_socket_send_dgram(void *opaque)
--
2.5.0