[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 6/9] log: log QMP commands and replies
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 6/9] log: log QMP commands and replies |
Date: |
Mon, 14 Mar 2016 17:40:36 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 |
On 14/03/2016 17:16, Denis V. Lunev wrote:
>> BTW, I'm not against adding this to QEMU in general - just pointing out
>> that in the context of libvirt usage reference in the commit message,
>> it is not really needed. I'm totally ambivalent wrt adding this to QEMU
>> for benefit of non-libvirt usage.
>
> I see. This just requires very clear commit message from my side.
> Thank you for a discussion.
I think this is not a compelling usage of the logging subsystem; QMP is
always used through a character device, and character devices already
have a logging mechanism.
Adding a mechanism that looks for '\n' in the data written to a
character device and emits a timestamp on the next character would be a
useful addition. I'd be entirely happy with adding it now, it should be
safe enough that we can do it during soft freeze.
Paolo
- Re: [Qemu-devel] [PATCH 1/9] trace: do not always call exit() in trace_enable_events, (continued)
- [Qemu-devel] [PATCH 6/9] log: log QMP commands and replies, Denis V. Lunev, 2016/03/14
- Re: [Qemu-devel] [PATCH 6/9] log: log QMP commands and replies, Paolo Bonzini, 2016/03/14
- Re: [Qemu-devel] [PATCH 6/9] log: log QMP commands and replies, Daniel P. Berrange, 2016/03/14
- Re: [Qemu-devel] [PATCH 6/9] log: log QMP commands and replies, Denis V. Lunev, 2016/03/14
- Re: [Qemu-devel] [PATCH 6/9] log: log QMP commands and replies, Daniel P. Berrange, 2016/03/14
- Re: [Qemu-devel] [PATCH 6/9] log: log QMP commands and replies, Denis V. Lunev, 2016/03/14
- Re: [Qemu-devel] [PATCH 6/9] log: log QMP commands and replies, Paolo Bonzini, 2016/03/14
- Re: [Qemu-devel] [PATCH 6/9] log: log QMP commands and replies, Daniel P. Berrange, 2016/03/14
- Re: [Qemu-devel] [PATCH 6/9] log: log QMP commands and replies, Denis V. Lunev, 2016/03/14
- Re: [Qemu-devel] [PATCH 6/9] log: log QMP commands and replies,
Paolo Bonzini <=
- Re: [Qemu-devel] [PATCH 6/9] log: log QMP commands and replies, Denis V. Lunev, 2016/03/16
- Re: [Qemu-devel] [PATCH 6/9] log: log QMP commands and replies, Paolo Bonzini, 2016/03/16
- Re: [Qemu-devel] [PATCH 6/9] log: log QMP commands and replies, Daniel P. Berrange, 2016/03/17
- Re: [Qemu-devel] [PATCH 6/9] log: log QMP commands and replies, Denis V. Lunev, 2016/03/14
[Qemu-devel] [PATCH 7/9] log: report HMP command and event, Denis V. Lunev, 2016/03/14
[Qemu-devel] [PATCH 9/9] log: adds a timestamp to each log entry, Denis V. Lunev, 2016/03/14