[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v8 5/9] qemu-log: new option -dfilter to limit o
From: |
Alex Bennée |
Subject: |
Re: [Qemu-devel] [PATCH v8 5/9] qemu-log: new option -dfilter to limit output |
Date: |
Mon, 14 Mar 2016 17:24:57 +0000 |
User-agent: |
mu4e 0.9.17; emacs 25.0.92.5 |
Richard Henderson <address@hidden> writes:
> On 03/04/2016 03:18 AM, Alex Bennée wrote:
>> + case '+':
>> + {
>> + unsigned long len;
>> + err |= qemu_strtoull(r2, NULL, 0, &len);
>> + if (len > 0) {
>> + range.end = range.begin + (len - 1);
>> + } else {
>> + err |= true;
>> + }
>> + break;
>> + }
>> + case '-':
>> + {
>> + unsigned long len;
>> + err |= qemu_strtoull(r2, NULL, 0, &len);
>> + range.end = range.begin;
>> + range.begin = range.end - len;
>> + break;
>> + }
>
> Doesn't '-' have the same off-by-one bug?
Doh. of course, I'll get that fixed.
> Although really I don't understand the need for negative ranges...
It's a shortcut, something went wrong at X, lets dump the code from X-n
to X to catch the run up to it.
>
>
> r~
--
Alex Bennée
- [Qemu-devel] [PATCH v8 0/9] qemu-log, -dfilter and other logging tweaks, Alex Bennée, 2016/03/04
- [Qemu-devel] [PATCH v8 1/9] tcg: pass down TranslationBlock to tcg_code_gen, Alex Bennée, 2016/03/04
- [Qemu-devel] [PATCH v8 3/9] qemu-log: Avoid function call for disabled qemu_log_mask logging, Alex Bennée, 2016/03/04
- [Qemu-devel] [PATCH v8 2/9] qemu-log: correct help text for -d cpu, Alex Bennée, 2016/03/04
- [Qemu-devel] [PATCH v8 4/9] qemu-log: Improve the "exec" TB execution logging, Alex Bennée, 2016/03/04
- [Qemu-devel] [PATCH v8 7/9] target-arm: dfilter support for in_asm, Alex Bennée, 2016/03/04
- [Qemu-devel] [PATCH v8 5/9] qemu-log: new option -dfilter to limit output, Alex Bennée, 2016/03/04
- [Qemu-devel] [PATCH v8 6/9] qemu-log: dfilter-ise exec, out_asm, op and opt_op, Alex Bennée, 2016/03/04
- [Qemu-devel] [PATCH v8 8/9] qemu-log: support simple pid substitution for logs, Alex Bennée, 2016/03/04
- [Qemu-devel] [PATCH v8 9/9] cputlb: modernise the debug support, Alex Bennée, 2016/03/04