[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] ppc64: set MSR_SF bit
From: |
Laurent Vivier |
Subject: |
Re: [Qemu-devel] [PATCH] ppc64: set MSR_SF bit |
Date: |
Wed, 16 Mar 2016 11:05:24 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 |
On 16/03/2016 10:48, Alexander Graf wrote:
>
>
> On 16.03.16 10:43, Laurent Vivier wrote:
>> When a qemu-system-ppc64 is started, the 64-bit mode bit
>> is not set in MSR.
>>
>> Signed-off-by: Laurent Vivier <address@hidden>
>
> I guess commit 2cf3eb6df552cee74b52de9989e270b74e42847e broke this. I'm
> surprised it didn't cause us more problems :).
Linux kernel is ready to manage that: see enable_64b_mode in
arch/powerpc/kernel/head_64.S
> Reviewed-by: Alexander Graf <address@hidden>
Thanks,
Laurent
>> ---
>> target-ppc/translate_init.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c
>> index bd0cffc..d7a1aeb 100644
>> --- a/target-ppc/translate_init.c
>> +++ b/target-ppc/translate_init.c
>> @@ -9663,7 +9663,7 @@ static void ppc_cpu_reset(CPUState *s)
>>
>> #if defined(TARGET_PPC64)
>> if (env->mmu_model & POWERPC_MMU_64) {
>> - env->msr |= (1ULL << MSR_SF);
>> + msr |= (1ULL << MSR_SF);
>> }
>> #endif
>>
>>
Re: [Qemu-devel] [Qemu-ppc] [PATCH] ppc64: set MSR_SF bit, David Gibson, 2016/03/20