[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 43/49] arm: move arm_log_exception into .c file
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 43/49] arm: move arm_log_exception into .c file |
Date: |
Wed, 16 Mar 2016 11:18:09 +0000 |
On 16 March 2016 at 10:46, Paolo Bonzini <address@hidden> wrote:
> Avoid need for qemu/log.h inclusion.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> target-arm/helper.c | 14 ++++++++++++++
> target-arm/internals.h | 15 +--------------
> 2 files changed, 15 insertions(+), 14 deletions(-)
>
> diff --git a/target-arm/helper.c b/target-arm/helper.c
> index eaded41..f71a78f 100644
> --- a/target-arm/helper.c
> +++ b/target-arm/helper.c
> @@ -5810,6 +5810,20 @@ static void do_v7m_exception_exit(CPUARMState *env)
> pointer. */
> }
>
> +void arm_log_exception(int idx)
> +{
> + if (qemu_loglevel_mask(CPU_LOG_INT)) {
> + const char *exc = NULL;
> +
> + if (idx >= 0 && idx < ARRAY_SIZE(excnames)) {
> + exc = excnames[idx];
> + }
> + if (!exc) {
> + exc = "unknown";
> + }
> + qemu_log_mask(CPU_LOG_INT, "Taking exception %d [%s]\n", idx, exc);
> + }
> +}
> void arm_v7m_cpu_do_interrupt(CPUState *cs)
> {
Missing blank line after '}'.
Also, arm_log_exception() is now only used in helper.c so you could just
make it static in this file.
thanks
-- PMM
- [Qemu-devel] [PATCH 33/49] hw: do not use VMSTATE_*TL, (continued)
- [Qemu-devel] [PATCH 33/49] hw: do not use VMSTATE_*TL, Paolo Bonzini, 2016/03/16
- [Qemu-devel] [PATCH 44/49] mips: move CP0 functions out of cpu.h, Paolo Bonzini, 2016/03/16
- [Qemu-devel] [PATCH 46/49] exec: extract exec/tb-context.h, Paolo Bonzini, 2016/03/16
- [Qemu-devel] [PATCH 27/49] arm: remove useless cpu.h inclusion, Paolo Bonzini, 2016/03/16
- [Qemu-devel] [PATCH 34/49] hw: move CPU state serialization to migration/cpu.h, Paolo Bonzini, 2016/03/16
- [Qemu-devel] [PATCH 39/49] gdbstub: remove includes from gdbstub-xml.c, Paolo Bonzini, 2016/03/16
- [Qemu-devel] [PATCH 40/49] dma: do not depend on kvm_enabled(), Paolo Bonzini, 2016/03/16
- [Qemu-devel] [PATCH 37/49] qemu-common: stop including qemu/bswap.h from qemu-common.h, Paolo Bonzini, 2016/03/16
- [Qemu-devel] [PATCH 38/49] qemu-common: stop including qemu/host-utils.h from qemu-common.h, Paolo Bonzini, 2016/03/16
- [Qemu-devel] [PATCH 43/49] arm: move arm_log_exception into .c file, Paolo Bonzini, 2016/03/16
- Re: [Qemu-devel] [PATCH 43/49] arm: move arm_log_exception into .c file,
Peter Maydell <=
- [Qemu-devel] [PATCH 48/49] hw: remove pio_addr_t, Paolo Bonzini, 2016/03/16
- [Qemu-devel] [PATCH 49/49] hw: clean up hw/hw.h includes, Paolo Bonzini, 2016/03/16
- [Qemu-devel] [PATCH 45/49] hw: explicitly include qemu/log.h, Paolo Bonzini, 2016/03/16
- [Qemu-devel] [PATCH 47/49] cpu: move exec-all.h inclusion out of cpu.h, Paolo Bonzini, 2016/03/16