[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 13/14] qapi: Allow anonymous base for flat un
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v5 13/14] qapi: Allow anonymous base for flat union |
Date: |
Wed, 16 Mar 2016 16:21:55 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Eric Blake <address@hidden> writes:
> On 03/10/2016 01:22 PM, Markus Armbruster wrote:
>> Eric Blake <address@hidden> writes:
>>
>>> Rather than requiring all flat unions to explicitly create
>>> a separate base struct, we can allow the qapi schema to specify
>>> the common members via an inline dictionary. This is similar to
>>> how commands can specify an inline anonymous type for its 'data'.
>>> We already have several struct types that only exist to serve as
>>> a single flat union's base; the next commit will clean them up
>>> (in particular, the doc change to the BlockdevOptions example in
>>> this patch will be reflected to QMP in the next).
>>
>> The parenthesis is a bit cryptic. "Reflected"?
>
> Maybe s/reflected to/implemented in/ would read better.
What about:
a single flat union's base; the next commit will clean them up.
In particular, this patch's change to the BlockdevOptions example
in qapi-code-gen.txt will actually be done in the real QAPI schema.
[...]
- [Qemu-devel] [PATCH v5 05/14] qapi: Emit implicit structs in generated C, (continued)
[Qemu-devel] [PATCH v5 13/14] qapi: Allow anonymous base for flat union, Eric Blake, 2016/03/09
[Qemu-devel] [PATCH v5 14/14] qapi: Use anonymous bases in QMP flat unions, Eric Blake, 2016/03/09
[Qemu-devel] [PATCH v5 11/14] qapi: Don't special-case simple union wrappers, Eric Blake, 2016/03/09
Re: [Qemu-devel] [PATCH v5 00/14] easier unboxed visits/qapi implicit types, Markus Armbruster, 2016/03/10