[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V6 1/2] net/filter-mirror: implement filter-redi
|
From: |
Jason Wang |
|
Subject: |
Re: [Qemu-devel] [PATCH V6 1/2] net/filter-mirror: implement filter-redirector |
|
Date: |
Thu, 17 Mar 2016 15:59:13 +0800 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 |
On 03/17/2016 03:50 PM, Li Zhijian wrote:
>>
>> +static void filter_redirector_fini(Object *obj)
>> +{
>> + MirrorState *s = FILTER_REDIRECTOR(obj);
>> +
>> + qemu_chr_add_handlers(s->chr_in, NULL, NULL, NULL, NULL);
>
> hi, Jason
> Do we reset the chardev handler here is reasonable ?
> filter_redirector_fini() is destruction of filter_redirector_init()
> which we
> don't register handler.
>
> So, I think move the handler reset to filter_redirector_cleanup()
> would be better.
>
> Thanks
> Li
Yes, please.
Thanks