[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 10/15] nvdimm acpi: abstract the operations for
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH 10/15] nvdimm acpi: abstract the operations for root device and nvdimm devices |
Date: |
Thu, 17 Mar 2016 10:35:38 +0000 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Thu, Mar 17, 2016 at 04:32:56PM +0800, Xiao Guangrong wrote:
> +static void
> +nvdimm_dsm_function0(uint32_t supported_func, hwaddr dsm_mem_addr)
> +{
> + NvdimmDsmFunc0Out func0 = {
> + .len = cpu_to_le32(sizeof(func0)),
> + .supported_func = cpu_to_le32(supported_func),
> + };
> + cpu_physical_memory_write(dsm_mem_addr, &func0, sizeof(func0));
> +}
> +
> +static void
> +nvdimm_dsm_no_payload(uint32_t func_ret_status, hwaddr dsm_mem_addr)
> +{
> + NvdimmDsmFuncNoPayloadOut out = {
> + .len = cpu_to_le32(sizeof(out)),
> + .func_ret_status = cpu_to_le32(func_ret_status),
> + };
> + cpu_physical_memory_write(dsm_mem_addr, &out, sizeof(out));
> +}
> +
> +static void nvdimm_dsm_root(NvdimmDsmIn *in, hwaddr dsm_mem_addr)
> +{
> + /*
> + * function 0 is called to inquire which functions are supported by
> + * OSPM
> + */
> + if (!in->function) {
> + return nvdimm_dsm_function0(0 /* No function supported other
> + than function 0 */, dsm_mem_addr);
The return type is void so "return foo()" looks strange. I went back
and double-checked function prototypes because I was surprised by this
line of code. Please use the conventional "foo(); return;" for void
return instead.
signature.asc
Description: PGP signature
- [Qemu-devel] [PATCH 02/15] pc-dimm: introduce realize callback, (continued)
- [Qemu-devel] [PATCH 02/15] pc-dimm: introduce realize callback, Xiao Guangrong, 2016/03/17
- [Qemu-devel] [PATCH 05/15] acpi: add aml_object_type, Xiao Guangrong, 2016/03/17
- [Qemu-devel] [PATCH 03/15] pc-dimm: keep the state of the whole backend memory, Xiao Guangrong, 2016/03/17
- [Qemu-devel] [PATCH 04/15] nvdimm: support nvdimm label, Xiao Guangrong, 2016/03/17
- [Qemu-devel] [PATCH 06/15] acpi: add aml_call5, Xiao Guangrong, 2016/03/17
- [Qemu-devel] [PATCH 07/15] nvdimm acpi: set HDLE properly, Xiao Guangrong, 2016/03/17
- [Qemu-devel] [PATCH 08/15] nvdimm acpi: save arg3 of _DSM method, Xiao Guangrong, 2016/03/17
- [Qemu-devel] [PATCH 10/15] nvdimm acpi: abstract the operations for root device and nvdimm devices, Xiao Guangrong, 2016/03/17
- Re: [Qemu-devel] [PATCH 10/15] nvdimm acpi: abstract the operations for root device and nvdimm devices,
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH 09/15] nvdimm acpi: check UUID, Xiao Guangrong, 2016/03/17
- [Qemu-devel] [PATCH 11/15] nvdimm acpi: check revision, Xiao Guangrong, 2016/03/17
- [Qemu-devel] [PATCH 13/15] nvdimm acpi: support Get Namespace Label Data function, Xiao Guangrong, 2016/03/17
- [Qemu-devel] [PATCH 12/15] nvdimm acpi: support Get Namespace Label Size function, Xiao Guangrong, 2016/03/17
- [Qemu-devel] [PATCH 14/15] nvdimm acpi: support Set Namespace Label Data function, Xiao Guangrong, 2016/03/17
- [Qemu-devel] [PATCH 15/15] docs: add NVDIMM ACPI documentation, Xiao Guangrong, 2016/03/17
- Re: [Qemu-devel] [PATCH 00/15] NVDIMM: introduce nvdimm label support, Stefan Hajnoczi, 2016/03/17