[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/5] tcg: code_bitmap is not used by user-mode e
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 1/5] tcg: code_bitmap is not used by user-mode emulation |
Date: |
Thu, 17 Mar 2016 14:56:52 +0000 |
On 17 March 2016 at 13:46, <address@hidden> wrote:
> From: Paolo Bonzini <address@hidden>
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> Signed-off-by: Sergey Fedorov <address@hidden>
> ---
> translate-all.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/translate-all.c b/translate-all.c
> index e9f409b762ab..f17ace1ae899 100644
> --- a/translate-all.c
> +++ b/translate-all.c
> @@ -784,6 +784,9 @@ void tb_free(TranslationBlock *tb)
>
> static inline void invalidate_page_bitmap(PageDesc *p)
> {
> +#ifndef CONFIG_SOFTMMU
> + assert(p->code_bitmap == NULL);
> +#endif
> g_free(p->code_bitmap);
> p->code_bitmap = NULL;
> p->code_write_count = 0;
> @@ -1018,6 +1021,7 @@ void tb_phys_invalidate(TranslationBlock *tb,
> tb_page_addr_t page_addr)
> tcg_ctx.tb_ctx.tb_phys_invalidate_count++;
> }
You could pretty much take this another step and actually
make the field in the struct be only present ifdef CONFIG_SOFTMMU...
thanks
-- PMM
- [Qemu-devel] [PATCH 0/5] tcg: Misc clean-up patches from Paolo, sergey . fedorov, 2016/03/17
- [Qemu-devel] [PATCH 4/5] tcg: reorder removal from lists in tb_phys_invalidate, sergey . fedorov, 2016/03/17
- [Qemu-devel] [PATCH 3/5] tcg: always keep jump target and tb->jmp_next consistent, sergey . fedorov, 2016/03/17
- [Qemu-devel] [PATCH 5/5] tcg: move tb_invalidated_flag to CPUState, sergey . fedorov, 2016/03/17
- [Qemu-devel] [PATCH 2/5] tcg: reorganize tb_find_physical loop, sergey . fedorov, 2016/03/17
- [Qemu-devel] [PATCH 1/5] tcg: code_bitmap is not used by user-mode emulation, sergey . fedorov, 2016/03/17
- Re: [Qemu-devel] [PATCH 1/5] tcg: code_bitmap is not used by user-mode emulation,
Peter Maydell <=