[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v6 11/16] qapi: Drop unused c_null()
From: |
Eric Blake |
Subject: |
[Qemu-devel] [PATCH v6 11/16] qapi: Drop unused c_null() |
Date: |
Thu, 17 Mar 2016 16:48:36 -0600 |
Now that we are always bulk-initializing a QAPI C struct to 0
(whether by g_malloc0() or by 'Type arg = {0};'), we no longer
have any clients of c_null() in the generator for per-element
initialization. This patch is easy enough to revert if we find
a use in the future, but in the present, get rid of the dead code.
Signed-off-by: Eric Blake <address@hidden>
---
v6: tweak commit message
v5: new patch
---
scripts/qapi.py | 46 +++++++++++++++++-----------------------------
1 file changed, 17 insertions(+), 29 deletions(-)
diff --git a/scripts/qapi.py b/scripts/qapi.py
index 3b50e4d..08d63bf 100644
--- a/scripts/qapi.py
+++ b/scripts/qapi.py
@@ -836,9 +836,6 @@ class QAPISchemaType(QAPISchemaEntity):
def c_unboxed_type(self):
return self.c_type()
- def c_null(self):
- return 'NULL'
-
def json_type(self):
pass
@@ -854,14 +851,13 @@ class QAPISchemaType(QAPISchemaEntity):
class QAPISchemaBuiltinType(QAPISchemaType):
- def __init__(self, name, json_type, c_type, c_null):
+ def __init__(self, name, json_type, c_type):
QAPISchemaType.__init__(self, name, None)
assert not c_type or isinstance(c_type, str)
assert json_type in ('string', 'number', 'int', 'boolean', 'null',
'value')
self._json_type_name = json_type
self._c_type_name = c_type
- self._c_null_val = c_null
def c_name(self):
return self.name
@@ -874,9 +870,6 @@ class QAPISchemaBuiltinType(QAPISchemaType):
return 'const ' + self._c_type_name
return self._c_type_name
- def c_null(self):
- return self._c_null_val
-
def json_type(self):
return self._json_type_name
@@ -909,10 +902,6 @@ class QAPISchemaEnumType(QAPISchemaType):
def member_names(self):
return [v.name for v in self.values]
- def c_null(self):
- return c_enum_const(self.name, (self.member_names() + ['_MAX'])[0],
- self.prefix)
-
def json_type(self):
return 'string'
@@ -1240,9 +1229,8 @@ class QAPISchema(object):
def lookup_type(self, name):
return self.lookup_entity(name, QAPISchemaType)
- def _def_builtin_type(self, name, json_type, c_type, c_null):
- self._def_entity(QAPISchemaBuiltinType(name, json_type,
- c_type, c_null))
+ def _def_builtin_type(self, name, json_type, c_type):
+ self._def_entity(QAPISchemaBuiltinType(name, json_type, c_type))
# TODO As long as we have QAPI_TYPES_BUILTIN to share multiple
# qapi-types.h from a single .c, all arrays of builtins must be
# declared in the first file whether or not they are used. Nicer
@@ -1251,20 +1239,20 @@ class QAPISchema(object):
self._make_array_type(name, None)
def _def_predefineds(self):
- for t in [('str', 'string', 'char' + pointer_suffix, 'NULL'),
- ('number', 'number', 'double', '0'),
- ('int', 'int', 'int64_t', '0'),
- ('int8', 'int', 'int8_t', '0'),
- ('int16', 'int', 'int16_t', '0'),
- ('int32', 'int', 'int32_t', '0'),
- ('int64', 'int', 'int64_t', '0'),
- ('uint8', 'int', 'uint8_t', '0'),
- ('uint16', 'int', 'uint16_t', '0'),
- ('uint32', 'int', 'uint32_t', '0'),
- ('uint64', 'int', 'uint64_t', '0'),
- ('size', 'int', 'uint64_t', '0'),
- ('bool', 'boolean', 'bool', 'false'),
- ('any', 'value', 'QObject' + pointer_suffix, 'NULL')]:
+ for t in [('str', 'string', 'char' + pointer_suffix),
+ ('number', 'number', 'double'),
+ ('int', 'int', 'int64_t'),
+ ('int8', 'int', 'int8_t'),
+ ('int16', 'int', 'int16_t'),
+ ('int32', 'int', 'int32_t'),
+ ('int64', 'int', 'int64_t'),
+ ('uint8', 'int', 'uint8_t'),
+ ('uint16', 'int', 'uint16_t'),
+ ('uint32', 'int', 'uint32_t'),
+ ('uint64', 'int', 'uint64_t'),
+ ('size', 'int', 'uint64_t'),
+ ('bool', 'boolean', 'bool'),
+ ('any', 'value', 'QObject' + pointer_suffix)]:
self._def_builtin_type(*t)
self.the_empty_object_type = QAPISchemaObjectType('q_empty', None,
None, [], None)
--
2.5.0
- [Qemu-devel] [PATCH v6 00/16] easier unboxed visits/qapi implicit types, Eric Blake, 2016/03/17
- [Qemu-devel] [PATCH v6 01/16] qapi: Assert in places where variants are not handled, Eric Blake, 2016/03/17
- [Qemu-devel] [PATCH v6 06/16] qapi-event: Drop qmp_output_get_qobject() null check, Eric Blake, 2016/03/17
- [Qemu-devel] [PATCH v6 02/16] qapi: Fix command with named empty argument type, Eric Blake, 2016/03/17
- [Qemu-devel] [PATCH v6 07/16] qapi-event: Utilize implicit struct visits, Eric Blake, 2016/03/17
- [Qemu-devel] [PATCH v6 09/16] qapi-commands: Inline single-use helpers of gen_marshal(), Eric Blake, 2016/03/17
- [Qemu-devel] [PATCH v6 13/16] qapi: Make BlockdevOptions doc example closer to reality, Eric Blake, 2016/03/17
- [Qemu-devel] [PATCH v6 16/16] qapi: Consolidate object visitors, Eric Blake, 2016/03/17
- [Qemu-devel] [PATCH v6 11/16] qapi: Drop unused c_null(),
Eric Blake <=
- [Qemu-devel] [PATCH v6 04/16] qapi: Adjust names of implicit types, Eric Blake, 2016/03/17
- [Qemu-devel] [PATCH v6 03/16] qapi: Make c_type() more OO-like, Eric Blake, 2016/03/17
- [Qemu-devel] [PATCH v6 10/16] qapi: Inline gen_visit_members() into lone caller, Eric Blake, 2016/03/17
- [Qemu-devel] [PATCH v6 05/16] qapi: Emit implicit structs in generated C, Eric Blake, 2016/03/17
- [Qemu-devel] [PATCH v6 08/16] qapi-commands: Utilize implicit struct visits, Eric Blake, 2016/03/17
- [Qemu-devel] [PATCH v6 14/16] qapi: Allow anonymous base for flat union, Eric Blake, 2016/03/17
- [Qemu-devel] [PATCH v6 15/16] qapi: Use anonymous bases in QMP flat unions, Eric Blake, 2016/03/17
- [Qemu-devel] [PATCH v6 12/16] qapi: Don't special-case simple union wrappers, Eric Blake, 2016/03/17
- Re: [Qemu-devel] [PATCH v6 00/16] easier unboxed visits/qapi implicit types, Markus Armbruster, 2016/03/18