[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/3] block: remove legacy_dinfo at blk_detach_de
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH 3/3] block: remove legacy_dinfo at blk_detach_dev time |
Date: |
Mon, 21 Mar 2016 18:39:57 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 21.03.2016 um 18:30 hat Markus Armbruster geschrieben:
> Paolo Bonzini <address@hidden> writes:
>
> > On 21/03/2016 17:15, Markus Armbruster wrote:
> >> * Explicitly with x-blockdev-del
> >>
> >> Fails unless no other reference exists. Where is the legacy_dinfo
> >> released?
> >
> > Can a -drive block device be deleted with x-blockdev-del even?!?
>
> When I wrote my review, I forgot that I expect x-blockdev-del to accept
> only backends created with blockdev-add. With that, my question is
> indeed moot.
>
> However, I've now tested my expectation, and it turned out to be wrong.
> I'm inclined to call that a bug.
Yes.
> > Shall I add a check to x-blockdev-del that gives an error if the
> > BlockBackend has a DriveInfo attached?
>
> Yes, please. But do double-check with Kevin & Max, who might have
> different ideas on blockdev-add/del than I do.
I'm pretty sure that I said that failing on -drive/drive_add created
BlockBackends was a requirement for x-blockdev-del. Apparently I failed
to catch the bug in the review then.
So go ahead and let's fix it now.
Kevin
- Re: [Qemu-devel] [PATCH 3/3] block: remove legacy_dinfo at blk_detach_dev time, (continued)
- Re: [Qemu-devel] [PATCH 3/3] block: remove legacy_dinfo at blk_detach_dev time, Paolo Bonzini, 2016/03/21
- Re: [Qemu-devel] [PATCH 3/3] block: remove legacy_dinfo at blk_detach_dev time, Markus Armbruster, 2016/03/21
- Re: [Qemu-devel] [PATCH 3/3] block: remove legacy_dinfo at blk_detach_dev time, Paolo Bonzini, 2016/03/21
- Re: [Qemu-devel] [PATCH 3/3] block: remove legacy_dinfo at blk_detach_dev time, Markus Armbruster, 2016/03/21
- Re: [Qemu-devel] [PATCH 3/3] block: remove legacy_dinfo at blk_detach_dev time, Kevin Wolf, 2016/03/22
- Re: [Qemu-devel] [PATCH 3/3] block: remove legacy_dinfo at blk_detach_dev time, Markus Armbruster, 2016/03/22
- Re: [Qemu-devel] [PATCH 3/3] block: remove legacy_dinfo at blk_detach_dev time, Paolo Bonzini, 2016/03/22
- Re: [Qemu-devel] [PATCH 3/3] block: remove legacy_dinfo at blk_detach_dev time, Markus Armbruster, 2016/03/23
- Re: [Qemu-devel] [PATCH 3/3] block: remove legacy_dinfo at blk_detach_dev time, Paolo Bonzini, 2016/03/23
- Re: [Qemu-devel] [PATCH 3/3] block: remove legacy_dinfo at blk_detach_dev time, Markus Armbruster, 2016/03/23
- Re: [Qemu-devel] [PATCH 3/3] block: remove legacy_dinfo at blk_detach_dev time,
Kevin Wolf <=
- Re: [Qemu-devel] [PATCH 3/3] block: remove legacy_dinfo at blk_detach_dev time, Markus Armbruster, 2016/03/21
- Re: [Qemu-devel] [PATCH 3/3] block: remove legacy_dinfo at blk_detach_dev time, Paolo Bonzini, 2016/03/22
- Re: [Qemu-devel] [PATCH 3/3] block: remove legacy_dinfo at blk_detach_dev time, Markus Armbruster, 2016/03/23