[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 07/11] block: move encryption deprecation war
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v6 07/11] block: move encryption deprecation warning into qcow code |
Date: |
Mon, 21 Mar 2016 14:04:51 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 |
On 03/21/2016 08:11 AM, Daniel P. Berrange wrote:
> or a couple of releases we have been warning
s/^or/For/
>
> Encrypted images are deprecated
> Support for them will be removed in a future release.
> You can use 'qemu-img convert' to convert your image to an unencrypted one.
>
> This warning was issued by system emulators, qemu-img, qemu-nbd
> and qemu-io. Such a broad warning was issued because the original
> intention was to rip out all the code for dealing with encryption
> inside the QEMU block layer APIs.
>
> The new block encryption framework used for the LUKS driver does
> not rely on the unloved block layer API for encryption keys,
> instead using the QOM 'secret' object type. It is thus no longer
> appropriate to warn about encryption unconditionally.
>
> When the qcow/qcow2 drivers are converted to use the new encryption
> framework too, it will be practical to keep AES-CBC support present
> for use in qemu-img, qemu-io & qemu-nbd to allow for interoperability
> with older QEMU versions and liberation of data from existing encrypted
> qcow2 files.
>
> This change moves the warning out of the generic block code and
> into the qcow/qcow2 drivers. Further, the warning is set to only
> appear when running the system emulators, since qemu-img, qemu-io,
> qemu-nbd are expected to support qcow2 encryption long term now that
> the maint burden has been eliminated.
>
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
> block.c | 12 +++++-------
> block/qcow.c | 9 +++++++++
> block/qcow2.c | 8 ++++++++
> include/block/block.h | 1 +
> tests/qemu-iotests/049.out | 6 ------
> tests/qemu-iotests/087 | 3 ++-
> tests/qemu-iotests/087.out | 26 ++++++++------------------
> tests/qemu-iotests/134.out | 18 ------------------
> 8 files changed, 33 insertions(+), 50 deletions(-)
>
With the typo fix,
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v6 03/11] tests: redirect stderr to stdout for iotests, (continued)
- [Qemu-devel] [PATCH v6 03/11] tests: redirect stderr to stdout for iotests, Daniel P. Berrange, 2016/03/21
- [Qemu-devel] [PATCH v6 05/11] tests: add output filter to python I/O tests helper, Daniel P. Berrange, 2016/03/21
- [Qemu-devel] [PATCH v6 01/11] block: add flag to indicate that no I/O will be performed, Daniel P. Berrange, 2016/03/21
- [Qemu-devel] [PATCH v6 02/11] qemu-img/qemu-io: don't prompt for passwords if not required, Daniel P. Berrange, 2016/03/21
- [Qemu-devel] [PATCH v6 08/11] block: add support for --image-opts in block I/O tests, Daniel P. Berrange, 2016/03/21
- [Qemu-devel] [PATCH v6 06/11] block: add generic full disk encryption driver, Daniel P. Berrange, 2016/03/21
- [Qemu-devel] [PATCH v6 07/11] block: move encryption deprecation warning into qcow code, Daniel P. Berrange, 2016/03/21
- Re: [Qemu-devel] [PATCH v6 07/11] block: move encryption deprecation warning into qcow code,
Eric Blake <=
- [Qemu-devel] [PATCH v6 09/11] block: add support for encryption secrets in block I/O tests, Daniel P. Berrange, 2016/03/21
- [Qemu-devel] [PATCH v6 10/11] block: enable testing of LUKS driver with block I/O tests, Daniel P. Berrange, 2016/03/21
- [Qemu-devel] [PATCH v6 11/11] block: an interoperability test for luks vs dm-crypt/cryptsetup, Daniel P. Berrange, 2016/03/21
- Re: [Qemu-devel] [PATCH v6 00/11] Add new LUKS block driver (for 2.6), Kevin Wolf, 2016/03/21
- Re: [Qemu-devel] [PATCH v6 00/11] Add new LUKS block driver (for 2.6), Kevin Wolf, 2016/03/23