[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL v2 40/40] contrib/ivshmem-server: Print "not for prod
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PULL v2 40/40] contrib/ivshmem-server: Print "not for production" warning |
Date: |
Mon, 21 Mar 2016 21:44:03 +0100 |
The code is okay for illustrating how things work and for testing, but
its error handling make it unfit for production use. Print a warning
to protect the innocent.
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>
Message-Id: <address@hidden>
---
contrib/ivshmem-server/main.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/contrib/ivshmem-server/main.c b/contrib/ivshmem-server/main.c
index 5afa8ee..dc64a18 100644
--- a/contrib/ivshmem-server/main.c
+++ b/contrib/ivshmem-server/main.c
@@ -200,6 +200,12 @@ main(int argc, char *argv[])
};
int ret = 1;
+ /*
+ * Do not remove this notice without adding proper error handling!
+ * Start with handling ivshmem_server_send_one_msg() failure.
+ */
+ printf("*** Example code, do not use in production ***\n");
+
/* parse arguments, will exit on error */
ivshmem_server_parse_args(&args, argc, argv);
--
2.4.3
- [Qemu-devel] [PULL v2 35/40] ivshmem: Replace int role_val by OnOffAuto master, (continued)
- [Qemu-devel] [PULL v2 35/40] ivshmem: Replace int role_val by OnOffAuto master, Markus Armbruster, 2016/03/21
- [Qemu-devel] [PULL v2 01/40] target-ppc: Document TOCTTOU in hugepage support, Markus Armbruster, 2016/03/21
- [Qemu-devel] [PULL v2 25/40] ivshmem: Receive shared memory synchronously in realize(), Markus Armbruster, 2016/03/21
- [Qemu-devel] [PULL v2 10/40] ivshmem: Rewrite specification document, Markus Armbruster, 2016/03/21
- [Qemu-devel] [PULL v2 39/40] ivshmem: Require master to have ID zero, Markus Armbruster, 2016/03/21
- [Qemu-devel] [PULL v2 03/40] ivshmem-server: Don't overload POSIX shmem and file name, Markus Armbruster, 2016/03/21
- [Qemu-devel] [PULL v2 19/40] ivshmem: Clean up MSI-X conditions, Markus Armbruster, 2016/03/21
- [Qemu-devel] [PULL v2 32/40] ivshmem: Simplify memory regions for BAR 2 (shared memory), Markus Armbruster, 2016/03/21
- [Qemu-devel] [PULL v2 37/40] ivshmem: Clean up after the previous commit, Markus Armbruster, 2016/03/21
- [Qemu-devel] [PULL v2 26/40] ivshmem: Propagate errors through ivshmem_recv_setup(), Markus Armbruster, 2016/03/21
- [Qemu-devel] [PULL v2 40/40] contrib/ivshmem-server: Print "not for production" warning,
Markus Armbruster <=
- [Qemu-devel] [PULL v2 36/40] ivshmem: Split ivshmem-plain, ivshmem-doorbell off ivshmem, Markus Armbruster, 2016/03/21
- [Qemu-devel] [PULL v2 21/40] ivshmem: Assert interrupts are set up once, Markus Armbruster, 2016/03/21
- [Qemu-devel] [PULL v2 33/40] ivshmem: Inline check_shm_size() into its only caller, Markus Armbruster, 2016/03/21
- [Qemu-devel] [PULL v2 28/40] ivshmem: Drop the hackish test for UNIX domain chardev, Markus Armbruster, 2016/03/21
- [Qemu-devel] [PULL v2 30/40] ivshmem: Tighten check of property "size", Markus Armbruster, 2016/03/21
- [Qemu-devel] [PULL v2 09/40] ivshmem-test: Improve test cases /ivshmem/server-*, Markus Armbruster, 2016/03/21
- [Qemu-devel] [PULL v2 23/40] ivshmem: Disentangle ivshmem_read(), Markus Armbruster, 2016/03/21
- Re: [Qemu-devel] [PULL v2 00/40] ivshmem: Fixes, cleanups, device model split, Peter Maydell, 2016/03/22