[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC 1/6] virtio-bus: common ioeventfd infrastruc
From: |
Cornelia Huck |
Subject: |
Re: [Qemu-devel] [PATCH RFC 1/6] virtio-bus: common ioeventfd infrastructure |
Date: |
Tue, 22 Mar 2016 09:08:58 +0100 |
On Tue, 22 Mar 2016 08:24:33 +0800
Fam Zheng <address@hidden> wrote:
> On Thu, 03/17 11:01, Cornelia Huck wrote:
> > diff --git a/include/hw/virtio/virtio-bus.h b/include/hw/virtio/virtio-bus.h
> > index 3f2c136..0281cbf 100644
> > --- a/include/hw/virtio/virtio-bus.h
> > +++ b/include/hw/virtio/virtio-bus.h
> > @@ -71,6 +71,16 @@ typedef struct VirtioBusClass {
> > void (*device_unplugged)(DeviceState *d);
> > int (*query_nvectors)(DeviceState *d);
> > /*
> > + * ioeventfd handling: if the transport implements ioeventfd_started,
> > + * it must implement the other ioeventfd callbacks as well
> > + */
> > + bool (*ioeventfd_started)(DeviceState *d);
> > + void (*ioeventfd_set_started)(DeviceState *d, bool started, bool err);
> > + bool (*ioeventfd_disabled)(DeviceState *d);
> > + void (*ioeventfd_set_disabled)(DeviceState *d, bool disabled);
> > + int (*ioeventfd_assign)(DeviceState *d, EventNotifier *notifier,
> > + int n, bool assign);
>
> Maybe we should consider documenting these operations and parameters?
Yes, we should :) I just wanted to make sure first that this is the way
to go.
- [Qemu-devel] [PATCH RFC 0/6] virtio: refactor host notifiers, Cornelia Huck, 2016/03/17
- [Qemu-devel] [PATCH RFC 1/6] virtio-bus: common ioeventfd infrastructure, Cornelia Huck, 2016/03/17
- [Qemu-devel] [PATCH RFC 3/6] virtio-ccw: convert to ioeventfd callbacks, Cornelia Huck, 2016/03/17
- [Qemu-devel] [PATCH RFC 5/6] virtio-mmio: convert to ioeventfd callbacks, Cornelia Huck, 2016/03/17
- [Qemu-devel] [PATCH RFC 4/6] virtio-pci: convert to ioeventfd callbacks, Cornelia Huck, 2016/03/17
- [Qemu-devel] [PATCH RFC 6/6] virtio-bus: remove old set_host_notifier callback, Cornelia Huck, 2016/03/17
- [Qemu-devel] [PATCH RFC 2/6] virtio-bus: have callers tolerate new host notifier api, Cornelia Huck, 2016/03/17
- Re: [Qemu-devel] [PATCH RFC 0/6] virtio: refactor host notifiers, Stefan Hajnoczi, 2016/03/21
- Re: [Qemu-devel] [PATCH RFC 0/6] virtio: refactor host notifiers, Fam Zheng, 2016/03/23