[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 06/20] xen_disk: Call blk_set_enable_write_cache
From: |
Stefano Stabellini |
Subject: |
Re: [Qemu-devel] [PATCH 06/20] xen_disk: Call blk_set_enable_write_cache() explicitly |
Date: |
Tue, 22 Mar 2016 11:08:00 +0000 (GMT) |
User-agent: |
Alpine 2.02 (DEB 1266 2009-07-14) |
On Fri, 18 Mar 2016, Kevin Wolf wrote:
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> hw/block/xen_disk.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/hw/block/xen_disk.c b/hw/block/xen_disk.c
> index 635328f..c358709 100644
> --- a/hw/block/xen_disk.c
> +++ b/hw/block/xen_disk.c
> @@ -888,12 +888,14 @@ static int blk_connect(struct XenDevice *xendev)
> struct XenBlkDev *blkdev = container_of(xendev, struct XenBlkDev,
> xendev);
> int pers, index, qflags;
> bool readonly = true;
> + bool writethrough = true;
>
> /* read-only ? */
> if (blkdev->directiosafe) {
> qflags = BDRV_O_NOCACHE | BDRV_O_NATIVE_AIO;
> } else {
> - qflags = BDRV_O_CACHE_WB;
> + qflags = 0;
You might as well initialize qflags to 0 above and leave it unchanged
here. In any case:
Acked-by: Stefano Stabellini <address@hidden>
> + writethrough = false;
> }
> if (strcmp(blkdev->mode, "w") == 0) {
> qflags |= BDRV_O_RDWR;
> @@ -925,6 +927,7 @@ static int blk_connect(struct XenDevice *xendev)
> error_free(local_err);
> return -1;
> }
> + blk_set_enable_write_cache(blkdev->blk, !writethrough);
> } else {
> /* setup via qemu cmdline -> already setup for us */
> xen_be_printf(&blkdev->xendev, 2, "get configured bdrv (cmdline
> setup)\n");
> --
> 1.8.3.1
>
>
- [Qemu-devel] [PATCH 00/20] block: Implement writethrough in BlockBackend, Kevin Wolf, 2016/03/18
- [Qemu-devel] [PATCH 02/20] qemu-nbd: Call blk_set_enable_write_cache() explicitly, Kevin Wolf, 2016/03/18
- [Qemu-devel] [PATCH 01/20] block: Add bdrv_parse_cache_mode(), Kevin Wolf, 2016/03/18
- [Qemu-devel] [PATCH 04/20] qemu-img: Expand all BDRV_O_FLAGS uses, Kevin Wolf, 2016/03/18
- [Qemu-devel] [PATCH 03/20] qemu-io: Call blk_set_enable_write_cache() explicitly, Kevin Wolf, 2016/03/18
- [Qemu-devel] [PATCH 06/20] xen_disk: Call blk_set_enable_write_cache() explicitly, Kevin Wolf, 2016/03/18
- [Qemu-devel] [PATCH 09/20] block: Handle flush error in bdrv_pwrite_sync(), Kevin Wolf, 2016/03/18
- [Qemu-devel] [PATCH 05/20] qemu-img: Call blk_set_enable_write_cache() explicitly, Kevin Wolf, 2016/03/18
- [Qemu-devel] [PATCH 07/20] block: blockdev_init(): Call blk_set_enable_write_cache() explicitly, Kevin Wolf, 2016/03/18
- [Qemu-devel] [PATCH 08/20] block: Always set writeback mode in blk_new_open(), Kevin Wolf, 2016/03/18
- [Qemu-devel] [PATCH 10/20] block: Move enable_write_cache to BB level, Kevin Wolf, 2016/03/18