|
From: | Cao jin |
Subject: | Re: [Qemu-devel] [PATCH RFC v2 1/2] Add param Error** to msi_init() & modify the callers |
Date: | Wed, 23 Mar 2016 17:23:40 +0800 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 |
On 03/23/2016 04:12 PM, Markus Armbruster wrote:
Cao jin <address@hidden> writes:
Really appreciate your review, I just finished reading all the comments and discussion. Seems pci_add_capability2()(commit cd9aa33e introduced) doesn`t follow the new error reporting rule(report error while also return error).Misunderstanding? "Report an error to the user" means error_report() and such. error_setg() doesn't report to the user, it returns an error object to the caller.
ah...thanks for correcting me.
So I am thinking, could we revert commit cd9aa33e, let pci_add_capability() return error code and assert when out of pci space, and let caller(only assigned device, others could ignore the error) handle the error code(new a error object, propagate it) Hope to hear PCI Maintainer`s advice(So I don`t cc other in this round)
-- Yours Sincerely, Cao jin
[Prev in Thread] | Current Thread | [Next in Thread] |