[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] trace: separate MMIO tracepoints from TB-ac
From: |
Hollis Blanchard |
Subject: |
Re: [Qemu-devel] [PATCH 2/2] trace: separate MMIO tracepoints from TB-access tracepoints |
Date: |
Wed, 23 Mar 2016 10:16:04 -0700 |
On Wed, 2016-03-23 at 17:53 +0100, Paolo Bonzini wrote:
>
> On 23/03/2016 17:47, Hollis Blanchard wrote:
> >
> > Paolo, is it true that only TB-invalidating writes go through the
> > io_mem_notdirty path? I'm looking at the live migration code now,
> > and it
> > seems like every memory write will go through that path when global
> > dirty memory logging is enabled.
> When live migration is enabled, writes to clean memory (almost all of
> them) will go through that path indeed. Some writes to the
> framebuffer
> will go through that path too.
>
> It depends on
>
> cpu_physical_memory_is_clean(
> memory_region_get_ram_addr(section->mr) +
> xlat))
>
> in tlb_set_page_with_attrs.
Would "memory_region_notdirty_read/write" be a better tracepoint name
than "memory_region_tb_read/write"?
--
Hollis Blanchard <address@hidden>
Mentor Graphics Emulation Division