[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 00/17] blockdev: Further BlockBackend work
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [PATCH v4 00/17] blockdev: Further BlockBackend work |
Date: |
Wed, 23 Mar 2016 20:06:34 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.0 |
On 17.03.2016 14:44, Kevin Wolf wrote:
> Am 16.03.2016 um 19:54 hat Max Reitz geschrieben:
>> This series appears to reinvent itself with every revision. This time,
>> its main implication is that BBs are no longer automatically treated as
>> monitor-owned, and that a BB's name is tightly tied to the monitor
>> reference (it is considered equivalent to that reference).
>
> Thanks, applied to the block branch.
Great. :-)
>> v4:
>> - blk_hide_on_behalf_of_hmp_drive_del() does a bit more than what
>> monitor_remove_blk() does; namely, it invokes bdrv_make_anon() on the
>> BDS. We should probably continue to do so.
>
> Probably not, removing the node-name of a BDS just because a BB
> disappears certainly feels like a bug. Even more so now that node-names
> are auto-generated and the general assumption is that all BDSes have
> one.
Yes, I meant in the sense of "It's what we did so far and I don't want
to mess with it in this series".
Max
> But that's a preexisting problem, so we can fix it on top.
>
> Kevin
>
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v4 05/17] qapi: Drop QERR_UNKNOWN_BLOCK_FORMAT_FEATURE, (continued)
- [Qemu-devel] [PATCH v4 05/17] qapi: Drop QERR_UNKNOWN_BLOCK_FORMAT_FEATURE, Max Reitz, 2016/03/16
- [Qemu-devel] [PATCH v4 13/17] block: Add bdrv_next_monitor_owned(), Max Reitz, 2016/03/16
- [Qemu-devel] [PATCH v4 10/17] blockdev: Split monitor reference from BB creation, Max Reitz, 2016/03/16
- [Qemu-devel] [PATCH v4 11/17] blockdev: Remove blk_hide_on_behalf_of_hmp_drive_del(), Max Reitz, 2016/03/16
- [Qemu-devel] [PATCH v4 14/17] block: Add blk_next_root_bs(), Max Reitz, 2016/03/16
- [Qemu-devel] [PATCH v4 12/17] block: Move some bdrv_*_all() functions to BB, Max Reitz, 2016/03/16
- [Qemu-devel] [PATCH v4 15/17] block: Rewrite bdrv_next(), Max Reitz, 2016/03/16
- [Qemu-devel] [PATCH v4 16/17] block: Use bdrv_next() instead of bdrv_states, Max Reitz, 2016/03/16
- [Qemu-devel] [PATCH v4 17/17] block: Remove bdrv_states list, Max Reitz, 2016/03/16
- Re: [Qemu-devel] [PATCH v4 00/17] blockdev: Further BlockBackend work, Kevin Wolf, 2016/03/17
- Re: [Qemu-devel] [PATCH v4 00/17] blockdev: Further BlockBackend work,
Max Reitz <=