[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 3/3] spice: Disallow use of gl + TCP port
From: |
Gerd Hoffmann |
Subject: |
[Qemu-devel] [PULL 3/3] spice: Disallow use of gl + TCP port |
Date: |
Thu, 24 Mar 2016 08:56:18 +0100 |
From: Christophe Fergeau <address@hidden>
Currently, virgl support has to go through a local unix socket, trying
to connect to a VM using -spice gl through spice://localhost:5900 will
only result in a black screen.
This commit errors out when the user tries to start a VM with both GL
support and a port/tls-port set.
This would fit better in spice-server, but currently QEMU does not call
into spice-server when parsing 'gl' on its command line, so we have to
do this check in QEMU instead.
Signed-off-by: Christophe Fergeau <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>
Message-id: address@hidden
[ applied codestyle fix: break long line ]
Signed-off-by: Gerd Hoffmann <address@hidden>
---
ui/spice-core.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/ui/spice-core.c b/ui/spice-core.c
index e117925..61db3c1 100644
--- a/ui/spice-core.c
+++ b/ui/spice-core.c
@@ -828,6 +828,11 @@ void qemu_spice_init(void)
#ifdef HAVE_SPICE_GL
if (qemu_opt_get_bool(opts, "gl", 0)) {
+ if ((port != 0) || (tls_port != 0)) {
+ error_report("SPICE GL support is local-only for now and "
+ "incompatible with -spice port/tls-port");
+ exit(1);
+ }
if (egl_rendernode_init() == 0) {
display_opengl = 1;
}
--
1.8.3.1