|
From: | Sergey Fedorov |
Subject: | Re: [Qemu-devel] [PATCH v2 4/5] ./configure: accept stems to match a range of targets |
Date: | Thu, 24 Mar 2016 19:46:09 +0300 |
24 марта 2016 г. 19:20 "Alex Bennée" <address@hidden>:
> Sergey Fedorov <address@hidden> writes:
> > On 24/03/16 19:05, Alex Bennée wrote:
> >> Sergey Fedorov <address@hidden> writes:
> >>
> >>> On 24/03/16 15:05, Alex Bennée wrote:
> >>>> Sergey Fedorov <address@hidden> writes:
> >>>>
> >>>>> On 23/03/16 20:20, Alex Bennée wrote:
> >>>>>> diff --git a/configure b/configure
> >>>>>> index b88d0db..ebf8a42 100755
> >>>>>> --- a/configure
> >>>>>> +++ b/configure
> >>>>>> @@ -1246,7 +1246,8 @@ Standard options:
> >>>>>> --target-list=LIST set target list (default: build everything)
> >>>>>> $(echo Available targets: $default_target_list | \
> >>>>>> fold -s -w 53 | sed -e 's/^/ /')
> >>>>>> -
> >>>>>> + LIST can contain stems to match sets of targets
> >>>>>> + (e.g. softmmu will match all softmmu targets)
> >>>>>> Advanced options (experts only):
> >>>>>> --source-path=PATH path of source code [$source_path]
> >>>>>> --cross-prefix=PREFIX use PREFIX for compile tools [$cross_prefix]
> >>>>> Maybe we'd better require user to specify the exact glob patterns in
> >>>>> '--target-list' to avoid possible misuse?
> >>>> Don't you run into problems of escaping glob patterns from the shell and
> >>>> the like? For example if I do:
> >>>>
> >>>> 12:04 address@hidden/x86_64 [qemu.git/mttcg/base-patches-v2] >./configure
> >>>> --target-list=arm*
> >>>>
> >>>> ERROR: Unknown target name 'arm-softmmu-config-devices.mak.d'
> >>>>
> >>>> As the shell picks up file names from the src dir.
> >>>>
> >>> Of course, it would be necessary to quote it like this:
> >>>
> >>> ./configure --target-list='arm*'
> >> Hmm shell quoting is a black art it seems:
> >>
> >> 16:04 address@hidden/x86_64 [qemu.git/travis/add-trusty-gce] >./configure --target-list='ar*'
> >>
> >> ERROR: Unknown target name 'arch_init.c'
> >
> > Right, it's inherent problem, I think :)
>
> Hence my decision to stick with stems ;-)
That is exactly the same problem as if you would like to do:
find -name '*.[ch]'
It will do the wrong thing if you miss quotes.
Regards,
Sergey
[Prev in Thread] | Current Thread | [Next in Thread] |