[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [patch v5 11/12] vfio: device may stuck in D3 when doin
From: |
Alex Williamson |
Subject: |
Re: [Qemu-devel] [patch v5 11/12] vfio: device may stuck in D3 when doing aer recovery |
Date: |
Thu, 24 Mar 2016 16:54:28 -0600 |
On Wed, 23 Mar 2016 18:12:06 +0800
Cao jin <address@hidden> wrote:
> From: Chen Fan <address@hidden>
>
> when a physical device aer occurred, the device state probably
> is not in D0 in a short time, if we recover the device quickly.
> we may stuck in D3 state when force to change device state to D0.
> we may need to wait for a short time to inject the error to guest.
>
> Signed-off-by: Chen Fan <address@hidden>
> ---
> hw/vfio/pci.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
> index 25fc095..5216e7f 100644
> --- a/hw/vfio/pci.c
> +++ b/hw/vfio/pci.c
> @@ -2658,6 +2658,9 @@ static void vfio_err_notifier_handler(void *opaque)
> msg.severity = isfatal ? PCI_ERR_ROOT_CMD_FATAL_EN :
> PCI_ERR_ROOT_CMD_NONFATAL_EN;
>
> + /* wait a bit to ensure aer device is ready */
> + usleep(2 * 1000);
Where does this number come from? Why would the device be in D3? I
don't understand this at all.
> +
> pcie_aer_msg(dev, &msg);
> return;
> }
- Re: [Qemu-devel] [patch v5 07/12] pci: add a pci_function_is_valid callback to check function if valid, (continued)
Re: [Qemu-devel] [patch v5 07/12] pci: add a pci_function_is_valid callback to check function if valid, Michael S. Tsirkin, 2016/03/27
[Qemu-devel] [patch v5 03/12] vfio: add pcie extended capability support, Cao jin, 2016/03/23
[Qemu-devel] [patch v5 06/12] vfio: add check host bus reset is support or not, Cao jin, 2016/03/23
[Qemu-devel] [patch v5 05/12] vfio: refine function vfio_pci_host_match, Cao jin, 2016/03/23
[Qemu-devel] [patch v5 08/12] vfio: add check aer functionality for hotplug device, Cao jin, 2016/03/23
[Qemu-devel] [patch v5 10/12] vfio-pci: pass the aer error to guest, Cao jin, 2016/03/23
[Qemu-devel] [patch v5 09/12] vfio: vote the function 0 to do host bus reset when aer occurred, Cao jin, 2016/03/23
[Qemu-devel] [patch v5 11/12] vfio: device may stuck in D3 when doing aer recovery, Cao jin, 2016/03/23
- Re: [Qemu-devel] [patch v5 11/12] vfio: device may stuck in D3 when doing aer recovery,
Alex Williamson <=
- Re: [Qemu-devel] [patch v5 11/12] vfio: device may stuck in D3 when doing aer recovery, Chen Fan, 2016/03/24
- Re: [Qemu-devel] [patch v5 11/12] vfio: device may stuck in D3 when doing aer recovery, Alex Williamson, 2016/03/24
- Re: [Qemu-devel] [patch v5 11/12] vfio: device may stuck in D3 when doing aer recovery, Chen Fan, 2016/03/31
- Re: [Qemu-devel] [patch v5 11/12] vfio: device may stuck in D3 when doing aer recovery, Alex Williamson, 2016/03/31
- Re: [Qemu-devel] [patch v5 11/12] vfio: device may stuck in D3 when doing aer recovery, Chen Fan, 2016/03/31
- Re: [Qemu-devel] [patch v5 11/12] vfio: device may stuck in D3 when doing aer recovery, Chen Fan, 2016/03/31
[Qemu-devel] [patch v5 12/12] vfio: add 'aer' property to expose aercap, Cao jin, 2016/03/23