[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [RFC PATCH 3/8] intel_iommu: allocate new key when creating
From: |
Jason Wang |
Subject: |
[Qemu-devel] [RFC PATCH 3/8] intel_iommu: allocate new key when creating new address space |
Date: |
Fri, 25 Mar 2016 10:13:24 +0800 |
We use the pointer to stack for key for new address space, this will break hash
table searching, fixing by g_malloc() a new key instead.
Cc: Michael S. Tsirkin <address@hidden>
Cc: Paolo Bonzini <address@hidden>
Cc: Richard Henderson <address@hidden>
Cc: Eduardo Habkost <address@hidden>
Signed-off-by: Jason Wang <address@hidden>
---
hw/i386/intel_iommu.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c
index d647b42..36b2072 100644
--- a/hw/i386/intel_iommu.c
+++ b/hw/i386/intel_iommu.c
@@ -1904,11 +1904,12 @@ VTDAddressSpace *vtd_find_add_as(IntelIOMMUState *s,
PCIBus *bus, int devfn)
char name[128];
if (!vtd_bus) {
+ uintptr_t *new_key = g_malloc(sizeof(*new_key));
+ *new_key = (uintptr_t)bus;
/* No corresponding free() */
vtd_bus = g_malloc0(sizeof(VTDBus) + sizeof(VTDAddressSpace *) *
VTD_PCI_DEVFN_MAX);
vtd_bus->bus = bus;
- key = (uintptr_t)bus;
- g_hash_table_insert(s->vtd_as_by_busptr, &key, vtd_bus);
+ g_hash_table_insert(s->vtd_as_by_busptr, new_key, vtd_bus);
}
vtd_dev_as = vtd_bus->dev_as[devfn];
--
2.5.0
- [Qemu-devel] [RFC PATCH 0/8] virtio/vhost DMAR support, Jason Wang, 2016/03/24
- [Qemu-devel] [RFC PATCH 3/8] intel_iommu: allocate new key when creating new address space,
Jason Wang <=
- [Qemu-devel] [RFC PATCH 1/8] virtio: convert to use DMA api, Jason Wang, 2016/03/24
- [Qemu-devel] [RFC PATCH 4/8] exec: introduce address_space_get_iotlb_entry(), Jason Wang, 2016/03/24
- [Qemu-devel] [RFC PATCH 5/8] virtio-pci: address space translation service (ATS) support, Jason Wang, 2016/03/24
- [Qemu-devel] [RFC PATCH 6/8] intel_iommu: support device iotlb descriptor, Jason Wang, 2016/03/24